Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented May 20, 2025

修复关闭窗口时,智能隐藏状态未刷新的问题.

Summary by Sourcery

Bug Fixes:

  • Refresh smart hide state when closing windows by emitting isWindowOverlapChanged upon window removal

修复关闭窗口时,智能隐藏状态未刷新的问题.

PMS: BUG-317017
Log:
@BLumia BLumia requested a review from 18202781743 May 20, 2025 13:06
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • onWindowClientListChanged函数中,mightNeedRecheckDockOverlap变量用于优化性能,但未在函数开始时初始化,可能会导致未定义行为。
  • Q_EMIT isWindowOverlapChanged(isWindowOverlap());的调用可能会在短时间内频繁触发,影响性能。

是否建议立即修改:

@sourcery-ai
Copy link

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

Introduces a flag to detect window removals in onWindowClientListChanged and emits an overlap-change signal after removals to update smart-hide state when windows close.

File-Level Changes

Change Details Files
Emit overlap-change signal after window removals
  • Declare and initialize a flag to track removals
  • Set flag when erasing closed windows from m_windows
  • Emit isWindowOverlapChanged(isWindowOverlap()) if flag is true
panels/dock/x11dockhelper.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BLumia - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@BLumia BLumia merged commit f1849bc into linuxdeepin:master May 21, 2025
7 of 10 checks passed
@BLumia BLumia deleted the pms-317017 branch May 21, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants