-
Notifications
You must be signed in to change notification settings - Fork 55
chore: simplify window effect descriptions #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Removed redundant prefixes ("Optimal performance:", "Balance:", "Best
visuals:") from descriptions in main.qml
2. Updated translation files to match the simplified descriptions
3. This change makes the UI text more concise while maintaining clarity
4. The modification affects all language translations to ensure
consistency
chore: 简化窗口特效描述文本
1. 移除了 main.qml 中描述文本的多余前缀("最佳性能:"、"均衡:"、"最佳
视觉:")
2. 更新翻译文件以匹配简化后的描述文本
3. 这一改动使界面文本更加简洁同时保持清晰
4. 修改影响了所有语言翻译以确保一致性
pms: BUG-313277
Reviewer's GuideThis PR streamlines window effect descriptions by removing mode-prefixes from the UI text in main.qml and synchronously updating all translation source files to match the new concise sentences. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mhduiy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
chore: 简化窗口特效描述文本
pms: BUG-313277
Summary by Sourcery
Simplify the window effect mode descriptions by removing redundant prefixes and update all translation files to reflect the new, concise text
Enhancements: