-
Notifications
You must be signed in to change notification settings - Fork 55
fix: layershell calcular in x11 emulation #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideFixed scale factor application in bottom strut calculation for X11 layer shell emulation to ensure maximized windows respect the taskbar at non-default scaling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wineee - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review代码审查意见:
总体来说,代码改动是合理的,没有引入新的问题,但是建议进行更多的测试和代码审查来确保代码的质量和稳定性。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Log: fix bug 305717 系统缩放调整到125%,最大化应用窗口后会被任务栏覆盖
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Log: fix bug 305717 系统缩放调整到125%,最大化应用窗口后会被任务栏覆盖
Summary by Sourcery
Bug Fixes: