feat: enhance notification icon handling #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as title Log: as title
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideRefactored notification icon handling to fully support inline base64 data URIs, replace temporary file usage with a direct encoding function, and streamline fallback behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yixinshark - I've reviewed your changes - here's some feedback:
- The method
decodeImageToBase64is actually encoding an image into a base64 data URI—consider renaming it to something likeencodeImageToBase64and add a null‐image guard to avoid producing invalid URIs. - The
imagePathOfNotificationchange removed the fallback to the application-x-desktop icon; please reintroduce a sensible default return value so you don’t end up returning an empty string when no image is provided. - You recreate the QRegularExpression on every call—consider making it a static or precompiled pattern to avoid unnecessary overhead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The method `decodeImageToBase64` is actually encoding an image into a base64 data URI—consider renaming it to something like `encodeImageToBase64` and add a null‐image guard to avoid producing invalid URIs.
- The `imagePathOfNotification` change removed the fallback to the application-x-desktop icon; please reintroduce a sensible default return value so you don’t end up returning an empty string when no image is provided.
- You recreate the QRegularExpression on every call—consider making it a static or precompiled pattern to avoid unnecessary overhead.
## Individual Comments
### Comment 1
<location> `panels/notification/bubble/bubbleitem.cpp:96` </location>
<code_context>
}
-static QImage decodeImageFromBase64(const QString &arg)
+static QString decodeImageToBase64(const QImage &image, const char *format = "PNG")
{
- if (arg.startsWith("data:image/")) {
</code_context>
<issue_to_address>
Function name may be misleading regarding its purpose.
Consider renaming the function to encodeImageToBase64 or imageToBase64Uri to better reflect that it encodes a QImage to a base64 data URI.
Suggested implementation:
```cpp
static QString encodeImageToBase64(const QImage &image, const char *format = "PNG")
```
If this function is called elsewhere in the file or project, those call sites should also be updated to use the new name `encodeImageToBase64`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| if (arg.startsWith("data:image/")) { | ||
| // iconPath is a string representing an inline image. | ||
| QStringList strs = arg.split("base64,"); | ||
| if (strs.length() == 2) { |
There was a problem hiding this comment.
suggestion: Function name may be misleading regarding its purpose.
Consider renaming the function to encodeImageToBase64 or imageToBase64Uri to better reflect that it encodes a QImage to a base64 data URI.
Suggested implementation:
static QString encodeImageToBase64(const QImage &image, const char *format = "PNG")
If this function is called elsewhere in the file or project, those call sites should also be updated to use the new name encodeImageToBase64.
18202781743
approved these changes
Jul 16, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
Log: as title
Summary by Sourcery
Convert notification icon handling to generate and return base64 data URIs instead of writing temporary files and using theme fallbacks
Enhancements: