Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jul 17, 2025

  1. Removed the dde-control-center-dock package definition from debian/ control
  2. The functionality has been moved to the control center
  3. This change reflects the consolidation of dock-related features into the main control center package

chore: 移除 dde-control-center-dock 包

  1. 从 debian/control 文件中移除了 dde-control-center-dock 包定义
  2. 相关功能已迁移至控制中心
  3. 此变更反映了将停靠栏相关功能整合到主控制中心包中

Summary by Sourcery

Build:

  • Remove dde-control-center-dock package definition from debian/control and integrate its features into dde-control-center

1. Removed the dde-control-center-dock package definition from debian/
control
2. The functionality has been moved to the control center
3. This change reflects the consolidation of dock-related features into
the main control center package

chore: 移除 dde-control-center-dock 包

1. 从 debian/control 文件中移除了 dde-control-center-dock 包定义
2. 相关功能已迁移至控制中心
3. 此变更反映了将停靠栏相关功能整合到主控制中心包中
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 17, 2025

Reviewer's Guide

The PR removes the standalone dde-control-center-dock package definition from debian/control and merges its functionality directly into the main dde-control-center package metadata, keeping the control center as the single entry point for dock features.

File-Level Changes

Change Details Files
Consolidated dock package into main control center
  • Removed the dde-control-center-dock stanza from debian/control
  • Merged dock-related features into dde-control-center package metadata
  • Updated the control center package description to include dock functionality
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见如下:

  1. 代码删除

    • 删除了dde-control-center-dock包的相关依赖和描述信息。如果这个包确实不再需要,那么删除是合理的。但是,如果这个包仍然需要保留,那么应该恢复这些信息。
  2. 依赖关系

    • 删除了dde-control-center-dock包的依赖项libdde-shell( =${binary:Version})。如果这个依赖项不再需要,那么删除是合理的。但是,如果这个包仍然需要这个依赖项,那么应该恢复这个依赖项。
  3. 冲突和替换

    • 删除了dde-control-center-dock包与dde-dock-dcc-plugin的冲突和替换信息。如果这个包不再需要与dde-dock-dcc-plugin冲突或替换,那么删除是合理的。但是,如果这个包仍然需要这些信息,那么应该恢复这些信息。
  4. 描述信息

    • 删除了dde-control-center-dock包的描述信息。如果这个包不再需要描述信息,那么删除是合理的。但是,如果这个包仍然需要描述信息,那么应该恢复这些信息。
  5. 一致性

    • 如果dde-control-center-dock包仍然需要保留,那么应该确保所有相关的信息(依赖项、冲突、替换、描述等)都保持一致。
  6. 文档和注释

    • 如果删除了dde-control-center-dock包,应该更新相关的文档和注释,以反映这一变化。

综上所述,如果dde-control-center-dock包确实不再需要,那么删除这些信息是合理的。但是,如果这个包仍然需要保留,那么应该恢复这些信息,并确保所有相关的信息保持一致。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
Copy link
Contributor Author

mhduiy commented Jul 17, 2025

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Jul 17, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 97f61c8 into linuxdeepin:master Jul 17, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants