-
Notifications
You must be signed in to change notification settings - Fork 55
fix: reduce app item border width #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the border width of the app item from 2px to 1px to create a more subtle and visually appealing appearance. The previous 2px border was too prominent and created visual clutter in the task manager interface. This adjustment improves the overall aesthetic by making the border less obtrusive while still maintaining the visual separation between app items. Influence: 1. Verify app items in the dock display with thinner borders 2. Check that the border is still visible but less prominent 3. Test hover and active states to ensure border visibility is appropriate 4. Verify the change doesn't affect the layout or spacing of app items 5. Test with different themes to ensure consistent appearance fix: 减小应用项边框宽度 将应用项的边框宽度从2像素改为1像素,以创建更微妙和视觉上更吸引人的外观。 之前的2像素边框过于突出,在任务管理器界面中造成了视觉混乱。此调整通过使 边框不那么突兀来改善整体美观性,同时仍保持应用项之间的视觉分隔。 Influence: 1. 验证坞站中的应用项是否显示更细的边框 2. 检查边框仍然可见但不太突出 3. 测试悬停和活动状态,确保边框可见性适当 4. 验证更改不会影响应用项的布局或间距 5. 使用不同主题测试以确保外观一致
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refines the visual style of dock task manager app items by reducing their outline thickness from 2px to 1px, making borders less visually dominant while preserving separation between items. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider binding the border width to a theme or shared style constant instead of a hard-coded
1, so that the appearance can be tuned consistently across different components and themes. - You may want to verify that a fixed 1px border scales well on HiDPI displays; if not, using
Qt.devicePixelRatioor a scalable unit could keep the border visually consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider binding the border width to a theme or shared style constant instead of a hard-coded `1`, so that the appearance can be tuned consistently across different components and themes.
- You may want to verify that a fixed 1px border scales well on HiDPI displays; if not, using `Qt.devicePixelRatio` or a scalable unit could keep the border visually consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review我来对这段代码变更进行审查:
建议:
Item {
property int borderWidth: 1
Rectangle {
border.width: borderWidth
// ...
}
}
总的来说,这是一个简单合理的UI优化修改,可以让界面看起来更加精致。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Changed the border width of the app item from 2px to 1px to create a more subtle and visually appealing appearance. The previous 2px border was too prominent and created visual clutter in the task manager interface. This adjustment improves the overall aesthetic by making the border less obtrusive while still maintaining the visual separation between app items.
Influence:
fix: 减小应用项边框宽度
将应用项的边框宽度从2像素改为1像素,以创建更微妙和视觉上更吸引人的外观。
之前的2像素边框过于突出,在任务管理器界面中造成了视觉混乱。此调整通过使
边框不那么突兀来改善整体美观性,同时仍保持应用项之间的视觉分隔。
Influence:
Summary by Sourcery
Enhancements: