fix(notification): improve action button background styling

[add-uos]

improve action button background styling

log: improve action button background styling
bug: PMS-350965

Summary by Sourcery

Improve visual styling of notification action button backgrounds to use a consistent themed background color without drop shadows.

Bug Fixes:

• Adjust notification action button background colors for better appearance in normal and dark modes.

Enhancements:

• Define a reusable palette-based background color for notification action buttons and apply it to the relevant controls.

[deepin-ci-robot]

deepin pr auto review

这段代码的 diff 展示了对 NotifyAction.qml 文件中两个位置的修改，主要涉及背景色和阴影属性的添加。以下是对这段代码的详细审查和改进意见：

1. 语法逻辑审查

• 语法正确性：代码符合 QML 语法规范。Palette 的嵌套定义和 Qt.rgba 的使用方式都是正确的。
• 逻辑一致性：修改在两个不同的代码块（推测是不同的控件状态或鼠标区域）中重复应用了相同的样式逻辑。这保持了 UI 的一致性，逻辑上是合理的。

2. 代码质量审查

• 代码重复 (DRY 原则)：
  • 问题：backgroundColor 的定义（包含 Palette 对象及其内部的 normal 和 normalDark）在两处完全相同。这违反了“不要重复自己”（DRY）的原则。如果将来需要调整这个半透明黑色的透明度，需要在两处同时修改，容易导致不一致。
  • 改进建议：建议将这个通用的背景色定义提取到文件的根层级，或者定义为一个 Component 或单独的 QML 单文件（如果这是一个通用样式），然后在需要的地方通过 id 引用。
  • 示例：

    // 在文件根层级定义
    Component {
        id: semiTransparentBackground
        Palette {
            normal { common: Qt.rgba(0, 0, 0, 0.15) }
            normalDark { common: Qt.rgba(0, 0, 0, 0.2) }
        }
    }
    
    // 使用处
    backgroundColor: semiTransparentBackground

3. 代码性能审查

• 对象创建开销：
  • 问题：当前代码在属性绑定时直接实例化了新的 Palette 对象。虽然对于简单的 UI 元素开销不大，但如果这个控件被频繁创建或销毁（例如在列表视图中），重复创建相同的对象会带来微小的内存分配和 GC 压力。
  • 改进建议：同样采用上述“代码质量”中的建议，复用同一个对象实例，可以减少对象创建的开销。

4. 代码安全审查

• 硬编码的透明度值：
  • 问题：0.15 和 0.2 是硬编码的魔术数字。虽然这不属于安全漏洞，但不利于维护和主题化。
  • 改进建议：如果项目中有设计规范或主题系统，建议将这些透明度值定义为常量，或者从全局主题配置中读取。例如：Theme.opacity.mask。

5. 具体属性审查

• dropShadowColor: null：
  • 显式将阴影颜色设为 null 是个好习惯，这明确表示设计意图是去除阴影，防止继承父级或默认样式的阴影属性干扰视觉效果。
• radius: 6：
  • 圆角半径为 6，与背景色配合，通常用于实现卡片或按钮效果。建议确认 6 是否为项目 UI 规范中的标准值，同样建议避免硬编码。

总结与改进后的代码示例

主要改进点：消除重复代码，提取公共样式。

// 假设在文件顶部或合适位置定义通用属性
property Palette commonSemiTransparentBg: Palette {
    normal { common: Qt.rgba(0, 0, 0, 0.15) }
    normalDark { common: Qt.rgba(0, 0, 0, 0.2) }
}

// ... 在控件中使用 ...
Background {
    radius: 6
    outsideBorderColor: null
    insideBorderColor: null
    dropShadowColor: null
    backgroundColor: commonSemiTransparentBg // 引用定义好的属性
    anchors.fill: parent
    // ...
}

// ... 另一处控件中同样引用 ...
Background {
    radius: 6
    outsideBorderColor: null
    insideBorderColor: null
    dropShadowColor: null
    backgroundColor: commonSemiTransparentBg // 引用定义好的属性
    anchors.fill: parent
}

这样修改后，代码更加简洁、易维护，且性能略有提升。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refines notification action button visuals by introducing a shared palette-based background color and applying it consistently to button frames while disabling their drop shadows.

Class diagram for updated NotifyAction QML styling

classDiagram
    class NotifyAction {
        +signal gotoNextItem()
        +signal gotoNextButton()
        +signal gotoPrevItem()
        +Palette actionBackgroundColor
        +function focusFirstButton()
    }

    class Palette {
        +color normal_common
        +color normalDark_common
    }

    class Frame {
        +int radius
        +color outsideBorderColor
        +color insideBorderColor
        +color dropShadowColor
        +Palette backgroundColor
    }

    NotifyAction *-- Palette : actionBackgroundColor
    NotifyAction *-- Frame : actionButtonFrame1
    NotifyAction *-- Frame : actionButtonFrame2

    Palette <|-- ActionBackgroundPalette
    class ActionBackgroundPalette {
        +color normal_common = Qt.rgba(0,0,0,0.15)
        +color normalDark_common = Qt.rgba(0,0,0,0.2)
    }

    Frame <|-- ActionButtonFrame
    class ActionButtonFrame {
        +int radius = 6
        +color outsideBorderColor = null
        +color insideBorderColor = null
        +color dropShadowColor = null
        +Palette backgroundColor = NotifyAction.actionBackgroundColor
    }

Loading

File-Level Changes

Change	Details	Files
Introduce a reusable palette property for action button backgrounds to support normal and dark themes with semi-transparent black colors.	Add an actionBackgroundColor Palette property at the Control root scope. Define normal and normalDark states using semi-transparent Qt.rgba black values (0.15 and 0.2 alpha respectively).	panels/notification/plugin/NotifyAction.qml
Update action button Frame components to use the new background palette and remove drop shadows for a flatter look.	Set dropShadowColor to null on action button frame instances to disable shadows. Bind backgroundColor of the frames to root.actionBackgroundColor so both instances share consistent styling.	panels/notification/plugin/NotifyAction.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider renaming actionBackgroundColor to something like actionBackgroundPalette to better reflect that the property is a Palette object rather than a single color value.
• If actionBackgroundColor is not intended to be modified externally at runtime, declare it as a readonly property to make the intent clear and prevent accidental mutation.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider renaming `actionBackgroundColor` to something like `actionBackgroundPalette` to better reflect that the property is a `Palette` object rather than a single color value.
- If `actionBackgroundColor` is not intended to be modified externally at runtime, declare it as a `readonly property` to make the intent clear and prevent accidental mutation.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}