Skip to content

fix: fix notification settings opening via direct D-Bus call #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Mar 25, 2026
+15 −15
Merged

fix: fix notification settings opening via direct D-Bus call #1530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions panels/notification/center/notifyaccessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand Down Expand Up @@ -26,14 +26,6 @@ namespace notifycenter {
static const uint ShowNotificationTop = 7;
static const QString InvalidApp {"DS-Invalid-Apps"};
static const QStringList InvalidPinnedApps {InvalidApp};

static QDBusInterface controlCenterInterface()
{
return QDBusInterface("org.deepin.dde.ControlCenter1",
"/org/deepin/dde/ControlCenter1",
"org.deepin.dde.ControlCenter1");
}

class EventFilter : public QObject
{
// QObject interface
Expand Down Expand Up @@ -219,12 +211,20 @@ bool NotifyAccessor::applicationPin(const QString &appId) const
void NotifyAccessor::openNotificationSetting()
{
qDebug(notifyLog) << "Open notification setting";
QDBusReply<void> reply = controlCenterInterface().call("ShowPage",
"notification");
if (reply.error().isValid()) {
qWarning(notifyLog) << "Failed to Open notifycation setting" << reply.error().message();
return;
}
QDBusMessage msg = QDBusMessage::createMethodCall("org.deepin.dde.ControlCenter1",
"/org/deepin/dde/ControlCenter1",
"org.deepin.dde.ControlCenter1",
"ShowPage");
msg << "notification";
QDBusPendingCall call = QDBusConnection::sessionBus().asyncCall(msg);
QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(call, this);
connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](QDBusPendingCallWatcher *self) {
QDBusReply<void> reply = *self;
if (!reply.isValid()) {
qWarning(notifyLog) << "Failed to open notification setting:" << reply.error().message();
}
self->deleteLater();
});
}

void NotifyAccessor::onNotificationStateChanged(qint64 id, int processedType)
Expand Down
Loading