Skip to content

fix: show dock context menu on long press release #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fly602 wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −5
Open

fix: show dock context menu on long press release #1571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions panels/dock/package/main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ Window {
}
}

property bool isLongPressing: false
TapHandler {
acceptedButtons: Qt.LeftButton | Qt.RightButton
gesturePolicy: TapHandler.WithinBounds
Expand All @@ -438,6 +439,22 @@ Window {
viewDeactivated()
}
}
onLongPressed: {
console.debug("[Mouse Long Press] longPressed")
dockContainer.isLongPressing = true
}
onPressedChanged: {
console.debug("[Mouse Long Press] pressedChanged, pressed:", pressed, "isLongPressing:", dockContainer.isLongPressing)
if (!pressed && dockContainer.isLongPressing) {
dockContainer.isLongPressing = false
let lastActive = MenuHelper.activeMenu
MenuHelper.closeCurrent()
dockMenuLoader.active = true
if (lastActive !== dockMenuLoader.item) {
requestShowDockMenu()
}
}
}
}

//Touch screen click
Expand All @@ -453,11 +470,19 @@ Window {
viewDeactivated()
}
onLongPressed: {
let lastActive = MenuHelper.activeMenu
MenuHelper.closeCurrent()
dockMenuLoader.active = true
if (lastActive !== dockMenuLoader.item) {
requestShowDockMenu()
console.debug("[Touch Long Press] longPressed")
dockContainer.isLongPressing = true
}
onPressedChanged: {
console.debug("[Touch Long Press] pressedChanged, pressed:", pressed, "isLongPressing:", dockContainer.isLongPressing)
if (!pressed && dockContainer.isLongPressing) {
dockContainer.isLongPressing = false
let lastActive = MenuHelper.activeMenu
MenuHelper.closeCurrent()
dockMenuLoader.active = true
if (lastActive !== dockMenuLoader.item) {
requestShowDockMenu()
}
}
}
}
Expand Down
Loading