Skip to content

chore(debian): update version to 0.3.2#81

Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:tag-0.3.2
Jan 30, 2026
Merged

chore(debian): update version to 0.3.2#81
zccrs merged 1 commit intolinuxdeepin:masterfrom
wineee:tag-0.3.2

Conversation

@wineee
Copy link
Member

@wineee wineee commented Jan 29, 2026

Log: update

Summary by Sourcery

Chores:

  • Refresh Debian changelog metadata to reflect the 0.3.2 release.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian packaging changelog to reflect version 0.3.2 with an updated log entry.

File-Level Changes

Change Details Files
Bump Debian package changelog to version 0.3.2.
  • Update the version entry in the Debian changelog to 0.3.2.
  • Adjust the corresponding log/message text for the new release entry in the changelog.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

TAG Bot

TAG: 0.3.2
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这份 debian/changelog 的 diff 记录了 ddm(Deepin Display Manager,推测)从版本 0.3.1 升级到 0.3.2 的变更内容。

语法逻辑格式规范的角度来看,这份变更日志符合 Debian 的 changelog 格式标准,格式正确,没有明显的语法错误。

然而,从代码质量性能安全的角度审查这些提交信息,我们可以发现一些潜在的改进点和值得深入关注的领域。以下是详细的审查意见:

1. 代码安全

这是本次更新中最值得关注的亮点,也是风险最高的部分。

  • 关注点: fix: use async-signal-safe functions in mandatory phase
  • 审查意见:
    • 改进: 这是一个非常关键的修复。在信号处理函数或程序的"强制阶段"(通常指处理崩溃或异常退出的关键路径)中调用非异步信号安全的函数(如 malloc, printf 等)会导致死锁或未定义行为。修复这一点极大地提高了系统的稳定性。
    • 建议: 虽然这是修复,但建议在代码审查中重点检查具体替换成了哪些函数(例如 write 而不是 printf)。确保没有遗漏任何可能在信号上下文中被调用的非安全函数。

2. 代码逻辑与稳定性

  • 关注点:
    • fix: fix ddm crash on treeland crash
    • fix: fix second user cannot login & misbehaved logout
  • 审查意见:
    • 改进: 修复多用户登录和注销逻辑是显示管理器(DM)的核心功能。这些修复表明解决了状态管理上的竞态条件或状态机错误。
    • 风险: "treeland crash"(推测是 Wayland 合成器)导致 ddm 崩溃,说明之前的错误处理机制过于脆弱。
    • 建议:
      • 对于 treeland crash,建议确认 ddm 是否实现了看门狗机制或自动重启合成器的逻辑,而不仅仅是"不崩溃"。如果合成器崩溃,用户应该能够恢复会话或看到友好的错误提示,而不是黑屏。
      • 对于多用户登录,建议增加单元测试或集成测试,模拟快速切换用户、注销和并发登录的场景,防止状态机死锁。

3. 代码性能

  • 关注点:
    • fix: fix ddm high resource occupation after starting X11 session
    • fix: fix wayland client dispatch loop
    • chore: better wayland client event dispatch loop
  • 审查意见:
    • 改进: 修复资源占用过高(通常是 CPU 100% 或内存泄漏)和优化事件分发循环对于提升用户体验至关重要。
    • 建议:
      • 资源占用: 需要确认高资源占用的具体原因。如果是死循环(Busy Loop),修复后应关注 CPU 休眠策略;如果是内存泄漏,需要检查引用计数。建议使用 valgrindASan 进行回归测试。
      • 事件循环: "Better"(更好)这个词比较模糊。建议在代码提交记录或 PR 中详细说明优化的具体手段。例如:是否从轮询改为了 epoll?是否减少了不必要的唤醒?是否修复了事件丢失的问题?明确的描述有助于后续维护。

4. 代码质量

  • 关注点:
    • chore: clean dependencies
    • chore: add clang-format guide
  • 审查意见:
    • 改进: 清理依赖可以减少攻击面,加快编译速度。引入格式化指南有助于统一代码风格,提高可读性。
    • 建议:
      • 依赖清理: 务必确保没有移除运行时必需的动态库,否则会导致系统崩溃或功能缺失。建议在清理后进行完整的依赖关系分析(如 ldd 检查)。
      • 格式化: 确保在 CI/CD 流程中加入了 clang-format 检查,强制执行代码风格,防止后续提交引入格式不一致的代码。

5. 格式规范建议

虽然当前的 changelog 格式是正确的,但为了提高可读性,建议对提交信息的措辞进行微调:

  • 当前:fix: fix ddm crash on treeland crash

  • 建议:fix: prevent ddm from crashing when treeland crashes(避免重复使用 "fix" 和 "crash",语义更清晰)

  • 当前:fix: fix second user cannot login & misbehaved logout

  • 建议:fix: resolve issues with secondary user login and logout sequence(更加正式和具体)

总结

这个版本包含了一些非常重要的底层修复,特别是关于信号安全多会话管理的部分。

  1. 优先级: 必须重点测试信号安全修复和多用户登录场景。
  2. 性能: 验证 X11 会话启动后的资源占用情况,确保修复彻底。
  3. 文档: 建议将 "better wayland client event dispatch loop" 这种模糊的描述在内部文档或 Git Commit 中具体化,以便于未来的代码审查。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit ddfd1fa into linuxdeepin:master Jan 30, 2026
10 checks passed
@deepin-bot
Copy link

deepin-bot bot commented Jan 30, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 0.3.2
  • Tag SHA: 4910cb1c708713d6d5f948f226cbd1f54735289a
  • Commit SHA: cf5a19eefe04c537704745835f904a5709ae0501
  • Tag Message:
    Release ddm 0.3.2
    
    
  • Tagger:
    • Name: wineee
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants