fix: Update include paths for libimagevisualresult based on QT version#369
fix: Update include paths for libimagevisualresult based on QT version#369lzwind merged 2 commits intolinuxdeepin:masterfrom dengzhongyuan365-dev:master
Conversation
- Adjusted the include statements for libimagevisualresult to conditionally include the correct header file based on the QT version. - This change ensures compatibility with QT 6.0.0 and above by including libimagevisualresult6/visualresult.h, while maintaining support for earlier versions.
Reviewer's Guide by SourceryThis pull request updates the include paths for libimagevisualresult to ensure compatibility with QT 6.0.0 and above. It uses a preprocessor directive to conditionally include the correct header file based on the QT version. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @dengzhongyuan365-dev - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider defining a macro to avoid repeating the conditional include in multiple files.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Bump version to 6.5.18 Log: Bump version to 6.5.18
deepin pr auto review代码审查意见:
总结:
|
|
TAG Bot TAG: 6.5.18 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary by Sourcery
Bug Fixes: