Revert "feat: Introduce pzip high-performance parallel compression for ARM platform"#386
Merged
max-lvs merged 5 commits intolinuxdeepin:release/eaglefrom Apr 14, 2026
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR reverts the earlier introduction of the ARM-only pzip high‑performance compression plugin, restoring the previous libarchive/libzip behavior and heuristics, and removes all build, install, and runtime integration of pzip and its clipzip plugin. Sequence diagram for ARM slotCompress libarchive selection heuristicsequenceDiagram
actor User
participant MainWindow
participant CompressionEngine
participant LibarchivePlugin
participant LibzipPlugin
User ->> MainWindow: requestCompression(val)
MainWindow ->> MainWindow: slotCompress(val)
MainWindow ->> MainWindow: compute maxFileSize_ and m_stCompressParameter.qSize
alt ARM_aarch64
MainWindow ->> MainWindow: evaluate conditions
alt maxFileSize_ > 50MB
MainWindow ->> MainWindow: bUseLibarchive = true
else qSize > 200MB
MainWindow ->> MainWindow: bUseLibarchive = true
else qSize > 100MB and maxFileSize_ > 10MB
MainWindow ->> MainWindow: bUseLibarchive = true
else proportion > 0.6
MainWindow ->> MainWindow: bUseLibarchive = (maxFileSize_ / qSize) > 0.6
end
else Non_ARM
MainWindow ->> MainWindow: bUseLibarchive = false
end
alt bUseLibarchive == true
MainWindow ->> CompressionEngine: startCompression(LibarchivePlugin)
CompressionEngine ->> LibarchivePlugin: compressFiles()
else bUseLibarchive == false
MainWindow ->> CompressionEngine: startCompression(LibzipPlugin)
CompressionEngine ->> LibzipPlugin: compressFiles()
end
Class diagram for compression plugin architecture after pzip removalclassDiagram
class MainWindow {
- bool bUseLibarchive
- qint64 maxFileSize_
- CompressParameter m_stCompressParameter
+ void slotCompress(QVariant val)
}
class UiTools {
+ static ReadOnlyArchiveInterface* createInterface(QString fileName, bool bWrite)
}
class Plugin {
+ MetaData metaData()
}
class ReadOnlyArchiveInterface
class LibzipPlugin
class LibminizipPlugin
class LibarchivePlugin
class PzipPlugin_removed
class ClipzipPlugin_removed
MainWindow --> UiTools : uses
MainWindow --> ReadOnlyArchiveInterface : configures_compression
UiTools --> ReadOnlyArchiveInterface : createInterface
UiTools --> Plugin : iterates_offers
Plugin <|-- LibzipPlugin
Plugin <|-- LibminizipPlugin
Plugin <|-- LibarchivePlugin
Plugin <|-- PzipPlugin_removed
Plugin <|-- ClipzipPlugin_removed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In the ARM-specific compression selection logic, guard the
maxFileSize_ / m_stCompressParameter.qSizecomputation against a possibleqSize == 0to avoid division-by-zero in edge cases (e.g., empty selections). - The series of size/threshold checks in
slotCompressfor__aarch64__would be easier to maintain and reason about if extracted into a small helper function (e.g.,shouldUseLibarchiveForArm(...)) with clearly named parameters and possibly shared between call sites if used elsewhere.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the ARM-specific compression selection logic, guard the `maxFileSize_ / m_stCompressParameter.qSize` computation against a possible `qSize == 0` to avoid division-by-zero in edge cases (e.g., empty selections).
- The series of size/threshold checks in `slotCompress` for `__aarch64__` would be easier to maintain and reason about if extracted into a small helper function (e.g., `shouldUseLibarchiveForArm(...)`) with clearly named parameters and possibly shared between call sites if used elsewhere.
## Individual Comments
### Comment 1
<location path="src/source/mainwindow.cpp" line_range="1093-1094" />
<code_context>
+ bUseLibarchive = true;
+ }
+ // 大文件占比超过60%使用libarchive
+ else {
+ double maxFileSizeProportion = static_cast<double>(maxFileSize_) / static_cast<double>(m_stCompressParameter.qSize);
+ bUseLibarchive = maxFileSizeProportion > 0.6;
+ }
</code_context>
<issue_to_address>
**issue (bug_risk):** Guard against potential division by zero when computing maxFileSizeProportion.
If `m_stCompressParameter.qSize` can be 0 (e.g., empty selection or placeholder jobs), this will divide by zero. Consider guarding against `qSize == 0` (e.g., early-return or skipping this branch) before computing `maxFileSizeProportion`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1093
to
+1094
| else { | ||
| double maxFileSizeProportion = static_cast<double>(maxFileSize_) / static_cast<double>(m_stCompressParameter.qSize); |
There was a problem hiding this comment.
issue (bug_risk): Guard against potential division by zero when computing maxFileSizeProportion.
If m_stCompressParameter.qSize can be 0 (e.g., empty selection or placeholder jobs), this will divide by zero. Consider guarding against qSize == 0 (e.g., early-return or skipping this branch) before computing maxFileSizeProportion.
max-lvs
approved these changes
Apr 14, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #372
Summary by Sourcery
Revert the previously introduced pzip-based high-performance ZIP compression support and restore the prior compression behavior, particularly on ARM platforms.
Enhancements:
Build: