Skip to content

fix: U盘介质识别错误#307

Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom
wyu71:master
May 8, 2024
Merged

fix: U盘介质识别错误#307
lzwind merged 1 commit intolinuxdeepin:masterfrom
wyu71:master

Conversation

@wyu71
Copy link
Copy Markdown
Contributor

@wyu71 wyu71 commented May 8, 2024

剔除错误识别判断

Log: U盘介质识别错误
Bug: https://pms.uniontech.com/bug-view-250575.html

剔除错误识别判断

Log: U盘介质识别错误
Bug: https://pms.uniontech.com/bug-view-250575.html
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • HWGenerator::getDiskInfoFromSmartCtl函数中,使用(*it).contains("ln")来判断是否需要跳过磁盘信息,这种方式不够直观,建议使用更明确的判断条件或者注释说明。

是否建议立即修改:

  • 是,建议立即修改,因为当前的代码处理方式不够清晰,可能会导致后续的逻辑判断错误。同时,添加明确的注释可以帮助其他开发者更好地理解代码的意图。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 43a643c into linuxdeepin:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants