Skip to content

feat: Image format extension support#167

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom
Kakueeen:develop/snipe
Jul 23, 2025
Merged

feat: Image format extension support#167
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/snipefrom
Kakueeen:develop/snipe

Conversation

@Kakueeen
Copy link
Copy Markdown
Contributor

@Kakueeen Kakueeen commented Jul 23, 2025

Added support for HEIC, HEIF, and AVIF formats.

Log: Image format extension support
Task: https://pms.uniontech.com/task-view-378959.html

Summary by Sourcery

Enable HEIC, HEIF, and AVIF image format support by bundling necessary libheif plugins, configuring the plugin path, and updating the package version.

New Features:

  • Add support for HEIC, HEIF, and AVIF image formats

Enhancements:

  • Bundle libheif plugins for various codecs (AOM, dav1d, J2K, libde265, x265)
  • Configure LIBHEIF_PLUGIN_PATH via a profile script for plugin loading

Build:

  • Bump package version to 6.5.25.1 across architectures

Added support for HEIC, HEIF, and AVIF formats.

Log: Image format extension support
Task: https://pms.uniontech.com/task-view-378959.html
@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.5.25
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 23, 2025

Reviewer's Guide

This PR extends image format support by bumping the package version, bundling HEIC/HEIF/AVIF decoder plugins into the build, and configuring LIBHEIF_PLUGIN_PATH across all architecture-specific YAML build scripts.

File-Level Changes

Change Details Files
Package version bump
  • Updated version from 6.5.24.1 to 6.5.25.1
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml
Bundle libheif decoder plugins
  • Added listings for libheif plugins (aomdec, dav1d, j2kdec, libde265, x265)
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml
Configure LIBHEIF_PLUGIN_PATH at runtime
  • Extract package ID via awk
  • Create profile script exporting LIBHEIF_PLUGIN_PATH
  • Include profile script in the .install file
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

代码审查意见:

  1. 版本号更新

    • linglong.yaml文件中,版本号从6.5.24.1更新到6.5.25.1,这是一个合理的版本更新,但需要确认是否有相应的功能或修复内容与版本号的更新相关。
  2. 环境变量设置

    • linglong.yaml文件中,通过echo export LIBHEIF_PLUGIN_PATH=$PREFIX/lib/${TRIPLET}/libheif/plugins > $PREFIX/etc/profile设置环境变量,这可能会导致环境变量覆盖问题。建议使用export命令的完整形式,如export LIBHEIF_PLUGIN_PATH=$PREFIX/lib/${TRIPLET}/libheif/plugins,并确保在正确的位置执行此命令。
  3. 文件路径硬编码

    • linglong.yaml文件中,硬编码了http://10.20.64.92:8080/crimson_25.0作为源地址,这可能会导致在部署到不同环境时出现问题。建议使用配置文件或环境变量来管理这些路径。
  4. 重复代码

    • linglong.yaml文件中,bash ./deploy_dep "${LDD_FILES[@]}"echo $PREFIX/etc/profile >> "${ID_VALUE}.install"的代码在多个架构文件中重复出现,建议将公共代码提取到一个单独的脚本或函数中,以减少重复代码。
  5. 注释风格

    • linglong.yaml文件中,注释使用了#符号,建议使用#符号后跟空格来提高可读性,例如# plugins for libheif.so.1
  6. 日志和错误处理

    • linglong.yaml文件中,没有看到对mkdirecho命令执行结果的处理,建议添加错误处理逻辑,以防止在执行过程中出现错误。
  7. 文档更新

    • debian/changelog文件中,新增了一个feat类型的提交,但没有相应的文档更新说明,建议在提交信息中添加对新增功能的详细描述。
  8. 架构文件一致性

    • linglong.yaml文件中,sources部分在不同的架构文件中存在重复,建议检查并确保所有架构文件中的sources部分保持一致。

综上所述,代码的版本更新、环境变量设置、文件路径管理、重复代码、注释风格、日志和错误处理、文档更新以及架构文件一致性等方面需要改进。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kakueeen
Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot deepin-bot Bot merged commit a736035 into linuxdeepin:develop/snipe Jul 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants