Skip to content

Conversation

@JWWTSL
Copy link
Contributor

@JWWTSL JWWTSL commented Aug 27, 2025

log: Optimized translation

bug: https://pms.uniontech.com/bug-view-329081.html

Summary by Sourcery

Correct the Lao translations for read-only mode toggles and update the package version to 6.5.36.1 across build metadata and changelog.

Bug Fixes:

  • Fix Lao translations for 'Turn on Read-Only mode' and 'Turn off Read-Only mode'.

Build:

  • Bump deepin-editor package version to 6.5.36.1 in linglong.yaml for arm64, loong64, and default builds and update debian/changelog accordingly.

@github-actions
Copy link

TAG Bot

TAG: 6.5.36
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

deepin pr auto review

根据提供的git diff,我看到这是一个版本更新相关的变更,主要是将deepin-editor的版本从6.5.35.1更新到6.5.36.1,同时包含了一些翻译文件的更新。以下是我的审查意见:

  1. 版本更新:

    • 版本号从6.5.35.1更新到6.5.36.1是合理的,遵循了语义化版本规范(主版本号.次版本号.修订号.构建号)。
    • debian/changelog中的更新记录格式规范,包含了版本号、紧急程度、更新说明和作者信息。
  2. 翻译更新:

    • 翻译文件中的更新改进了老挝语(lo)的翻译质量,将"Turn on Read-Only mode"和"Turn off Read-Only mode"的翻译从不太准确的"ເປັນ mode ອອກສຽງ"和"ປັ້ນ off mode ອອກສຽງ"改进为更准确的"ເປີດໂໝດອ່ານຢ່າງດຽວ"和"ປິດໂໝດອ່ານຢ່າງດຽວ"。
  3. 改进建议:

    • 建议在changelog中添加更详细的更新说明,说明6.5.36.1版本具体修复了哪些问题或新增了哪些功能。
    • 确保所有架构(arm64、loong64等)的版本号更新保持一致,当前diff中已经做到了这点。
    • 翻译更新可以添加更多上下文信息,比如更新的具体原因或改进点。
  4. 代码质量:

    • 版本管理规范,所有相关文件中的版本号都保持同步更新。
    • changelog的格式符合Debian标准,包含了必要的信息。
  5. 性能和安全:

    • 本次更新主要是版本号和翻译的变更,不涉及核心功能代码,因此对性能和安全没有明显影响。

总体而言,这是一个规范且合理的版本更新,改进了翻译质量,保持了版本号的一致性。建议在未来的更新中提供更详细的变更说明,以便用户和开发者更好地了解更新内容。

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 27, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refines Lao translations for read-only mode toggles in the deepin-editor source and bumps the package version to 6.5.36.1 across YAML manifests and the Debian changelog.

File-Level Changes

Change Details Files
Update Lao translations for read-only mode toggles
  • Revised translation for 'Turn on Read-Only mode' to 'ເປີດໂໝດອ່ານຢ່າງດຽວ'
  • Revised translation for 'Turn off Read-Only mode' to 'ປິດໂໝດອ່ານຢ່າງດຽວ'
translations/deepin-editor_lo.ts
Bump package version to 6.5.36.1
  • Incremented version in arm64 manifest
  • Incremented version in primary linglong manifest
  • Incremented version in loong64 manifest
arm64/linglong.yaml
linglong.yaml
loong64/linglong.yaml
Update Debian changelog for new version
  • Added changelog entry for version 6.5.36.1
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Separate the version bump changes from the translation fixes into two PRs to keep each change set focused and easy to review.
  • Verify that the updated version in all linglong.yaml files aligns with the version declared in the Debian changelog and any other package metadata.
  • Have a native Lao speaker review the new translations for Read-Only mode to ensure they match the terminology used elsewhere in the UI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Separate the version bump changes from the translation fixes into two PRs to keep each change set focused and easy to review.
- Verify that the updated version in all linglong.yaml files aligns with the version declared in the Debian changelog and any other package metadata.
- Have a native Lao speaker review the new translations for Read-Only mode to ensure they match the terminology used elsewhere in the UI.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JWWTSL, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JWWTSL
Copy link
Contributor Author

JWWTSL commented Aug 27, 2025

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 27, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 8a992fd into linuxdeepin:master Aug 27, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants