-
Notifications
You must be signed in to change notification settings - Fork 73
chore: remove inner address #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Log: Change-Id: Ib57cc7df13749ccf670758b540172478afbb288e
Reviewer's GuideReplaces hard-coded internal repository URLs in both the C++ UI generator and the shell startup script with user-input placeholders to improve configurability. Class diagram for GenerateDialog after removing hardcoded addressclassDiagram
class GenerateDialog {
+void generate()
}
Flow diagram for configurable repository URL in container-up.shflowchart TD
A[Start container-up.sh] --> B[Set MIRROR to user input placeholder]
B --> C[Continue with network namespace and bridge setup]
C --> D[Container startup proceeds]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deepin-mozart - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/scripts/container-up.sh:20` </location>
<code_context>
BR_IP="172.16.0.1/16"
BR_GW="172.16.0.1"
-MIRROR="https://pools.uniontech.com/deepin"
+MIRROR="input your mirror address"
sudo ip netns add ${NETNS_ID}
</code_context>
<issue_to_address>
Using 'input your mirror address' as a default may break script functionality.
Add a validation check for MIRROR or provide clear instructions to update this variable before running the script.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| BR_IP="172.16.0.1/16" | ||
| BR_GW="172.16.0.1" | ||
| MIRROR="https://pools.uniontech.com/deepin" | ||
| MIRROR="input your mirror address" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Using 'input your mirror address' as a default may break script functionality.
Add a validation check for MIRROR or provide clear instructions to update this variable before running the script.
|
Note
详情{
"src/plugins/linglong/gui/generatedialog.cpp": [
{
"line": " source[\"url\"] = \"https://github.com/linuxdeepin/linglong-builder-demo.git\";",
"line_number": 181,
"rule": "S35",
"reason": "Url link | 8521449550"
}
]
} |
Log:
Change-Id: Ib57cc7df13749ccf670758b540172478afbb288e
Summary by Sourcery
Remove internal addresses by replacing hardcoded URLs with user-input placeholders
Enhancements: