Skip to content

fix: Enable qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 for MIPS architecture#228

Merged
lzwind merged 2 commits into
linuxdeepin:develop/snipefrom
dengzhongyuan365-dev:develop/snipe
Jun 20, 2025
Merged

fix: Enable qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 for MIPS architecture#228
lzwind merged 2 commits into
linuxdeepin:develop/snipefrom
dengzhongyuan365-dev:develop/snipe

Conversation

@dengzhongyuan365-dev
Copy link
Copy Markdown

fix: Enable qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 for MIPS architecture

- Uncommented qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 in the debian/control file to ensure they are included for MIPS architecture.
- This change enhances compatibility with both QT 5 and QT 6.

Log: Enable qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 for MIPS architecture

bug: https://pms.uniontech.com/bug-view-320881.html

…plates2 for MIPS architecture

- Uncommented qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 in the debian/control file to ensure they are included for MIPS architecture.
- This change enhances compatibility with both QT 5 and QT 6.

Log: Enable qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 for MIPS architecture

bug: https://pms.uniontech.com/bug-view-320881.html
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

代码审查意见:

  1. 版本号更新

    • arm64/linglong.yamldebian/changeloglinglong.yamlloong64/linglong.yaml文件中,版本号从6.5.25.1更新到6.5.26.1。确保这个版本号的更新是符合版本控制策略的,并且有相应的代码改动来支持这个版本更新。
  2. 注释的修改

    • debian/control文件中,注释掉了qml6-module-qtquick-controls2qml6-module-qtquick-templates2的注释,并直接添加了这些依赖项。这种修改应该是有意为之,以确保MIPS架构能够正确使用这些模块。但是,如果这些模块的注释是为了避免在非MIPS架构上安装,那么应该确保这些模块在非MIPS架构上也确实需要。
  3. 描述信息

    • linglong.yaml文件中,描述信息description: 4似乎是一个错误,应该是一个完整的描述。如果这是一个简化的描述,应该更正为完整的描述信息。
  4. 文件格式一致性

    • 确保所有YAML文件格式的一致性,特别是缩进和空格的使用。例如,debian/changelog文件中新增的行应该与之前的行保持一致的缩进和格式。
  5. 依赖项更新

    • debian/control文件中,依赖项的更新应该与实际代码改动保持一致。如果这些依赖项的更新是为了支持新的功能或修复问题,应该在提交信息中说明。
  6. 提交信息

    • debian/changelog文件中,提交信息应该简洁明了,并且包含足够的信息来理解这次提交的目的。例如,fix: Enable qml6-module-qtquick-controls2 and qml6-module-qtquick-templates2 for MIPS architecture应该更具体地说明为什么需要启用这些模块,以及它们是如何解决MIPS架构问题的。

综上所述,代码的修改看起来是有意为之,并且遵循了版本控制和依赖项管理的最佳实践。但是,需要确保描述信息的完整性和一致性,以及提交信息的清晰性。

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.5.26
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 772c617 into linuxdeepin:develop/snipe Jun 20, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants