feat: add default color mode configuration for print preview#116
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Nov 6, 2025
Merged
feat: add default color mode configuration for print preview#11618202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Contributor
Author
|
/topic dtk-cpv20 |
Contributor
|
Add topic: dtk-cpv20 successed. |
|
/integr-topic dtk-cpv20 |
Contributor
|
Integrated with pr deepin-community/Repository-Integration#3340 |
BLumia
approved these changes
Nov 6, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sync with dtkwidget/develop/eagle 309f339dfa9f45921efa2b32e9a5cb7b0cd686c5 Added two new configuration options for print preview color mode settings: 1. defaultColorMode - public setting with default value "color" for default color mode configuration 2. colorMode - private setting for current color mode configuration with empty default value These configurations support v20 migration requirements for print preview functionality, providing both a default color mode setting and a current color mode state management. The defaultColorMode is publicly accessible while colorMode is kept private for internal state tracking. Log: Added default color mode configuration option for print preview Influence: 1. Test print preview functionality with different color mode settings 2. Verify default color mode is properly applied when no specific mode is set 3. Check configuration persistence across application sessions 4. Validate that public defaultColorMode setting can be modified by users 5. Ensure private colorMode setting is not directly accessible to end users feat: 为打印预览添加默认色彩配置 新增两个打印预览色彩模式配置选项: 1. defaultColorMode - 公开设置,默认值为"color",用于配置默认色彩模式 2. colorMode - 私有设置,用于当前色彩模式配置,默认值为空 这些配置支持v20迁移的打印预览功能需求,提供默认色彩模式设置和当前色彩模 式状态管理。defaultColorMode为公开可访问,而colorMode保持私有用于内部状 态跟踪。 Log: 新增打印预览默认色彩配置选项 Influence: 1. 测试不同色彩模式设置下的打印预览功能 2. 验证未设置特定模式时默认色彩模式是否正确应用 3. 检查配置在应用程序会话间的持久性 4. 验证公开的defaultColorMode设置是否可被用户修改 5. 确保私有colorMode设置对最终用户不可直接访问
Contributor
deepin pr auto review我来对这个配置文件的修改进行审查:
改进建议:
"value": "default" // 或其他合适的默认值
"description": "Configure the color mode. Available values: 'light', 'dark', 'auto'",
"description[zh_CN]": "配置色彩模式。可选值:'light'(浅色)、'dark'(深色)、'auto'(自动)"
"type": "string" // 或其他适当的类型
"description[zh_CN]": "配置默认的色彩模式"
"validation": {
"type": "enum",
"values": ["light", "dark", "auto"]
}这些改进将使配置更加健壮和易于维护,同时提供更好的文档支持。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync with dtkwidget/develop/eagle
309f339dfa9f45921efa2b32e9a5cb7b0cd686c5
Added two new configuration options for print preview color mode
settings:
default color mode configuration
empty default value
These configurations support v20 migration requirements for print
preview functionality, providing both a default color mode setting and
a current color mode state management. The defaultColorMode is publicly
accessible while colorMode is kept private for internal state tracking.
Log: Added default color mode configuration option for print preview
Influence:
is set
users
users
feat: 为打印预览添加默认色彩配置
新增两个打印预览色彩模式配置选项:
这些配置支持v20迁移的打印预览功能需求,提供默认色彩模式设置和当前色彩模
式状态管理。defaultColorMode为公开可访问,而colorMode保持私有用于内部状
态跟踪。
Log: 新增打印预览默认色彩配置选项
Influence: