Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Dec 6, 2024

When the specified area is blurred, fallback to global blur is not supported

pms: TASK-368711

When the specified area is blurred, fallback to global blur is not supported

pms: TASK-368711
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • blurSuc 变量在每次调用 setWindowBlurAreaByWM 后都被重新赋值,可能不是必要的。
  • blurSuc 变量在最后被检查时,如果 setWindowBlurAreaByWM 返回 false,则调用 setEnableBlurWindow(true)。这可能会导致窗口始终启用模糊效果,即使之前的设置失败。

是否建议立即修改:

建议的修改:

  • 如果 blurSuc 变量在每次调用 setWindowBlurAreaByWM 后都被重新赋值,那么这个变量可能是不必要的。如果 setWindowBlurAreaByWM 只需要被调用一次,那么可以移除 blurSuc 变量。
  • 如果 setWindowBlurAreaByWM 返回 false 时调用 setEnableBlurWindow(true),这可能会导致窗口始终启用模糊效果,即使之前的设置失败。应该检查 setWindowBlurAreaByWM 的返回值,并在失败时采取适当的错误处理措施。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 6, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#429
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 5f0ec24 into linuxdeepin:master Dec 6, 2024
19 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Dec 6, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants