-
Notifications
You must be signed in to change notification settings - Fork 42
feat: add ScrollView component and update TextArea sizing #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added new ScrollView.qml component to chameleon and qt6 directories 2. Registered ScrollView type in qmlplugin 3. Updated TextArea.qml to improve implicit width/height calculations 4. ScrollView includes custom ScrollBar implementations for vertical and horizontal scrolling 5. Changes ensure consistent scrolling behavior and better text area sizing The additions provide a dedicated ScrollView component with Deepin DTK styling and proper scroll bar integration. The TextArea sizing updates make it more responsive to content changes while maintaining proper padding and insets. feat: 添加 ScrollView 组件并更新 TextArea 尺寸计算 1. 在 chameleon 和 qt6 目录中添加新的 ScrollView.qml 组件 2. 在 qmlplugin 中注册 ScrollView 类型 3. 更新 TextArea.qml 以改进隐式宽度/高度计算 4. ScrollView 包含垂直和水平滚动的自定义滚动条实现 5. 这些变更确保了一致的滚动行为和更好的文本区域尺寸计算 这些新增内容提供了具有 Deepin DTK 样式的专用 ScrollView 组件和适当的滚动 条集成。TextArea 尺寸更新使其对内容变化更加敏感,同时保持适当的填充和内 边距。
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#488
deepin pr auto review代码审查意见:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR adds a new Deepin-styled ScrollView component—complete with custom vertical and horizontal scrollbars—registers it in the QML plugin and build system, and refines TextArea’s implicit sizing to better account for content, background insets, and placeholder metrics. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#488
horizontal scrolling
sizing
The additions provide a dedicated ScrollView component with Deepin DTK
styling and proper scroll bar integration. The TextArea sizing updates
make it more responsive to content changes while maintaining proper
padding and insets.
feat: 添加 ScrollView 组件并更新 TextArea 尺寸计算
这些新增内容提供了具有 Deepin DTK 样式的专用 ScrollView 组件和适当的滚动
条集成。TextArea 尺寸更新使其对内容变化更加敏感,同时保持适当的填充和内
边距。
Summary by Sourcery
Add a ScrollView QML component with custom Deepin DTK scrollbars and update TextArea implicit sizing to better accommodate content and insets.
New Features:
Enhancements:
Build: