Skip to content

fix: correct dark theme color for warning button#508

Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Aug 8, 2025
Merged

fix: correct dark theme color for warning button#508
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 commented Aug 7, 2025

Added normalDark property to warningButton text palette to match normal
color in dark theme
Previously the dark theme variant was missing, causing display issues
This ensures consistent warning button appearance across both light and
dark themes

fix: 修正警告按钮在暗色主题下的颜色问题

为警告按钮文本调色板添加normalDark属性以匹配正常颜色
之前缺少暗色主题变体导致显示问题
现在确保警告按钮在明暗主题下外观一致

pms: BUG-327377

Summary by Sourcery

Bug Fixes:

  • Add normalDark property to warningButton text palette for dark theme consistency

Added normalDark property to warningButton text palette to match normal
color in dark theme
Previously the dark theme variant was missing, causing display issues
This ensures consistent warning button appearance across both light and
dark themes

fix: 修正警告按钮在暗色主题下的颜色问题

为警告按钮文本调色板添加normalDark属性以匹配正常颜色
之前缺少暗色主题变体导致显示问题
现在确保警告按钮在明暗主题下外观一致

pms: BUG-327377
@18202781743 18202781743 requested review from BLumia and mhduiy August 7, 2025 11:59
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#508
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

关键摘要:

  • 新增的 normalDark 属性直接引用了 normal 属性,这可能不是预期的行为,需要确认是否这是有意为之。

是否建议立即修改:

  • 是,需要确认新增的 normalDark 属性是否应该与 normal 属性保持一致,或者是否有特定的逻辑需要实现。如果这是无意的,应该立即修正以避免潜在的错误。

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Expose a dark theme color for warning button text by adding a normalDark property mapped to the existing normal color in FlowStyle.qml, ensuring consistent appearance across light and dark themes.

ER diagram for warningButton text palette color properties

erDiagram
    WARNING_BUTTON ||--o| PALETTE : uses
    PALETTE {
        string normal
        string normalDark
    }
Loading

Class diagram for updated warningButton text palette

classDiagram
    class warningButton {
        +D.Palette text
    }
    class D.Palette {
        +normal : color
        +normalDark : color
    }
    warningButton --> D.Palette : text
Loading

File-Level Changes

Change Details Files
Introduce dark theme variant for warning button text palette
  • Add normalDark property to warningButton text palette
  • Bind normalDark value to the existing normal color
qt6/src/qml/FlowStyle.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@18202781743 18202781743 merged commit 07e4c38 into linuxdeepin:master Aug 8, 2025
19 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants