fix: correct dark theme color for warning button#508
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Aug 8, 2025
Merged
fix: correct dark theme color for warning button#50818202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Added normalDark property to warningButton text palette to match normal color in dark theme Previously the dark theme variant was missing, causing display issues This ensures consistent warning button appearance across both light and dark themes fix: 修正警告按钮在暗色主题下的颜色问题 为警告按钮文本调色板添加normalDark属性以匹配正常颜色 之前缺少暗色主题变体导致显示问题 现在确保警告按钮在明暗主题下外观一致 pms: BUG-327377
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 7, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#508
Contributor
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExpose a dark theme color for warning button text by adding a normalDark property mapped to the existing normal color in FlowStyle.qml, ensuring consistent appearance across light and dark themes. ER diagram for warningButton text palette color propertieserDiagram
WARNING_BUTTON ||--o| PALETTE : uses
PALETTE {
string normal
string normalDark
}
Class diagram for updated warningButton text paletteclassDiagram
class warningButton {
+D.Palette text
}
class D.Palette {
+normal : color
+normalDark : color
}
warningButton --> D.Palette : text
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Aug 8, 2025
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added normalDark property to warningButton text palette to match normal
color in dark theme
Previously the dark theme variant was missing, causing display issues
This ensures consistent warning button appearance across both light and
dark themes
fix: 修正警告按钮在暗色主题下的颜色问题
为警告按钮文本调色板添加normalDark属性以匹配正常颜色
之前缺少暗色主题变体导致显示问题
现在确保警告按钮在明暗主题下外观一致
pms: BUG-327377
Summary by Sourcery
Bug Fixes: