feat: add smooth property support for DciIconImage#509
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Aug 8, 2025
Merged
feat: add smooth property support for DciIconImage#50918202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
1. Connect smooth property change signal from DQuickDciIconImage to QQuickImage 2. Initialize QQuickImage's smooth property during classBegin 3. Ensure smooth property synchronization between DQuickDciIconImage and internal QQuickImage Log: Added smooth property support for DciIconImage Influence: 1. Test smooth property propagation to underlying QQuickImage 2. Verify smooth property initialization during component creation 3. Check smooth property changes during runtime feat: 为DciIconImage添加smooth属性支持 1. 将DQuickDciIconImage的smooth属性变化信号连接到QQuickImage 2. 在classBegin阶段初始化QQuickImage的smooth属性 3. 确保DQuickDciIconImage和内部QQuickImage的smooth属性同步 Log: 新增DciIconImage的smooth属性支持 Influence: 1. 测试smooth属性是否正确传递到底层QQuickImage 2. 验证组件创建时smooth属性的初始化 3. 检查运行时smooth属性的变化效果 PMS: BUG-327609
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#509
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdd support for the “smooth” property in DciIconImage by forwarding changes from DQuickDciIconImage to its internal QQuickImage and initializing it during classBegin for runtime synchronization. Sequence diagram for smooth property synchronization between DQuickDciIconImage and QQuickImagesequenceDiagram
participant DQuickDciIconImage
participant QQuickImage
DQuickDciIconImage->>QQuickImage: setSmooth(smooth()) during classBegin
DQuickDciIconImage-->>QQuickImage: smoothChanged signal
QQuickImage->>QQuickImage: setSmooth(newValue)
Class diagram for smooth property propagation in DQuickDciIconImageclassDiagram
class DQuickDciIconImage {
+bool smooth
+signal smoothChanged(bool)
+void classBegin()
}
class QQuickImage {
+bool smooth
+void setSmooth(bool)
}
DQuickDciIconImage --> QQuickImage : owns imageItem
DQuickDciIconImage ..> QQuickImage : connect smoothChanged to setSmooth
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
mhduiy
approved these changes
Aug 8, 2025
robertkill
approved these changes
Aug 8, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Aug 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QQuickImage
internal QQuickImage
Log: Added smooth property support for DciIconImage
Influence:
feat: 为DciIconImage添加smooth属性支持
Log: 新增DciIconImage的smooth属性支持
Influence:
PMS: BUG-327609
Summary by Sourcery
New Features: