Skip to content

feat: add smooth property support for DciIconImage#509

Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Aug 8, 2025
Merged

feat: add smooth property support for DciIconImage#509
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 commented Aug 8, 2025

  1. Connect smooth property change signal from DQuickDciIconImage to
    QQuickImage
  2. Initialize QQuickImage's smooth property during classBegin
  3. Ensure smooth property synchronization between DQuickDciIconImage and
    internal QQuickImage

Log: Added smooth property support for DciIconImage

Influence:

  1. Test smooth property propagation to underlying QQuickImage
  2. Verify smooth property initialization during component creation
  3. Check smooth property changes during runtime

feat: 为DciIconImage添加smooth属性支持

  1. 将DQuickDciIconImage的smooth属性变化信号连接到QQuickImage
  2. 在classBegin阶段初始化QQuickImage的smooth属性
  3. 确保DQuickDciIconImage和内部QQuickImage的smooth属性同步

Log: 新增DciIconImage的smooth属性支持

Influence:

  1. 测试smooth属性是否正确传递到底层QQuickImage
  2. 验证组件创建时smooth属性的初始化
  3. 检查运行时smooth属性的变化效果

PMS: BUG-327609

Summary by Sourcery

New Features:

  • Add smooth property support for DciIconImage by connecting smoothChanged to the internal QQuickImage and initializing it during classBegin to keep them in sync

1. Connect smooth property change signal from DQuickDciIconImage to
QQuickImage
2. Initialize QQuickImage's smooth property during classBegin
3. Ensure smooth property synchronization between DQuickDciIconImage and
internal QQuickImage

Log: Added smooth property support for DciIconImage

Influence:
1. Test smooth property propagation to underlying QQuickImage
2. Verify smooth property initialization during component creation
3. Check smooth property changes during runtime

feat: 为DciIconImage添加smooth属性支持

1. 将DQuickDciIconImage的smooth属性变化信号连接到QQuickImage
2. 在classBegin阶段初始化QQuickImage的smooth属性
3. 确保DQuickDciIconImage和内部QQuickImage的smooth属性同步

Log: 新增DciIconImage的smooth属性支持

Influence:
1. 测试smooth属性是否正确传递到底层QQuickImage
2. 验证组件创建时smooth属性的初始化
3. 检查运行时smooth属性的变化效果

PMS: BUG-327609
@18202781743 18202781743 requested review from BLumia and mhduiy August 8, 2025 07:36
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#509
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 8, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Add support for the “smooth” property in DciIconImage by forwarding changes from DQuickDciIconImage to its internal QQuickImage and initializing it during classBegin for runtime synchronization.

Sequence diagram for smooth property synchronization between DQuickDciIconImage and QQuickImage

sequenceDiagram
    participant DQuickDciIconImage
    participant QQuickImage
    DQuickDciIconImage->>QQuickImage: setSmooth(smooth()) during classBegin
    DQuickDciIconImage-->>QQuickImage: smoothChanged signal
    QQuickImage->>QQuickImage: setSmooth(newValue)
Loading

Class diagram for smooth property propagation in DQuickDciIconImage

classDiagram
    class DQuickDciIconImage {
        +bool smooth
        +signal smoothChanged(bool)
        +void classBegin()
    }
    class QQuickImage {
        +bool smooth
        +void setSmooth(bool)
    }
    DQuickDciIconImage --> QQuickImage : owns imageItem
    DQuickDciIconImage ..> QQuickImage : connect smoothChanged to setSmooth
Loading

File-Level Changes

Change Details Files
Implement smooth property synchronization
  • Connected DQuickDciIconImage::smoothChanged to QQuickImage::setSmooth in the constructor
  • Initialized QQuickImage’s smooth property to match DQuickDciIconImage during classBegin
src/private/dquickdciiconimage.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 306320f into linuxdeepin:master Aug 8, 2025
18 of 19 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Aug 8, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants