Skip to content

fix(EditPanel): add z-index to AlertToolTip to prevent being blocked#595

Closed
add-uos wants to merge 1 commit intolinuxdeepin:masterfrom
add-uos:fix-353943
Closed

fix(EditPanel): add z-index to AlertToolTip to prevent being blocked#595
add-uos wants to merge 1 commit intolinuxdeepin:masterfrom
add-uos:fix-353943

Conversation

@add-uos
Copy link
Copy Markdown
Contributor

@add-uos add-uos commented Mar 30, 2026

Add z-index property to AlertToolTip component to ensure it displays on top of other UI elements. Set z-index to 10000 to prevent the alert tooltip from being hidden behind other components.

为AlertToolTip组件添加z-index属性,确保提示框显示在其他UI元素之上。
将z-index设置为10000,防止提示框被其他组件遮挡。

Log: 修复EditPanel提示框被遮挡问题
PMS: BUG-353943
Influence: 修复后EditPanel的AlertToolTip提示框将正常显示,不会被其他UI 元素遮挡,提升用户体验。

Summary by Sourcery

Bug Fixes:

  • Prevent the EditPanel AlertToolTip from being hidden behind overlapping UI components by assigning it a higher stacking order.

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 30, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Sets a high z-order for the EditPanel AlertToolTip so it reliably appears above other UI elements, resolving a visual overlap issue.

File-Level Changes

Change Details Files
Ensure the EditPanel AlertToolTip renders above other components by explicitly configuring its stacking order.
  • Add a z property to the AlertToolTip instance used in EditPanel
  • Set the z value to a high constant (10000) so the tooltip is not obscured by surrounding UI elements
qt6/src/qml/EditPanel.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider avoiding the hard-coded z: 10000 magic number by either defining a named constant or using a value relative to surrounding components so future layout changes are easier to reason about.
  • It may be safer to scope the higher z to only when showAlert is true (e.g., using a Binding or state), so the tooltip doesn't unintentionally block interactions when it is hidden or not needed.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider avoiding the hard-coded `z: 10000` magic number by either defining a named constant or using a value relative to surrounding components so future layout changes are easier to reason about.
- It may be safer to scope the higher `z` to only when `showAlert` is true (e.g., using a Binding or state), so the tooltip doesn't unintentionally block interactions when it is hidden or not needed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add z-index property to AlertToolTip component to ensure it displays on
top of other UI elements. Set z-index to 10000 to prevent the alert
tooltip from being hidden behind other components.

为AlertToolTip组件添加z-index属性,确保提示框显示在其他UI元素之上。
将z-index设置为10000,防止提示框被其他组件遮挡。

Log: 修复EditPanel提示框被遮挡问题
PMS: BUG-353943
Influence: 修复后EditPanel的AlertToolTip提示框将正常显示,不会被其他UI
元素遮挡,提升用户体验。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants