Skip to content

fix: fix content truncation with scrollable view#623

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0520-fix-issue-361037
May 21, 2026
Merged

fix: fix content truncation with scrollable view#623
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0520-fix-issue-361037

Conversation

@MyLeeJiEun
Copy link
Copy Markdown
Contributor

  1. Wrap the right content area in a Flickable to support vertical scrolling
  2. Add ScrollBar with AsNeeded policy for long content overflow
  3. Remove elide mode from description and acknowledgements labels
  4. Adjust layout margins for better content display

Log: Make AboutDialog content scrollable to prevent truncation

fix: 修复关于对话框内容截断问题

  1. 将右侧内容区域包裹在 Flickable 中支持垂直滚动
  2. 添加 ScrollBar 滚动条以处理长内容溢出
  3. 移除描述和致谢标签的省略模式
  4. 调整布局边距以改善内容显示

Log: 使关于对话框内容可滚动,防止内容被截断
PMS: BUG-361037

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MyLeeJiEun, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1. Wrap right content area in a Flickable with vertical ScrollBar to
   handle overflow when content exceeds dialog height
2. Fix content height calculation to use explicit height instead of
   implicitHeight for proper layout
3. Hide title bar label when title is empty using a Loader
4. Adjust padding to remove top and right padding for better alignment
5. Add bottom margin to acknowledgements section to prevent content
   cutoff at the bottom

Log: Fix about dialog content overflow by adding scrollable area and correct title bar layout

fix: 添加滚动支持并修复标题栏布局

1. 将右侧内容区域包裹在带垂直滚动条的 Flickable 中,解决内容超出
   对话框高度时的显示问题
2. 修复内容高度计算,使用显式高度替代 implicitHeight 以确保正确布局
3. 使用 Loader 在标题为空时隐藏标题栏文本
4. 调整内边距,移除顶部和右侧内边距以改善对齐效果
5. 为致谢部分添加底部边距,防止内容在底部被截断

Log: 修复关于对话框内容溢出问题,添加可滚动区域并修正标题栏布局
PMS: BUG-361037
@MyLeeJiEun MyLeeJiEun force-pushed the fork-from-master-0520-fix-issue-361037 branch from 01fee0c to 0a8a73c Compare May 20, 2026 10:13
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MyLeeJiEun
Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot deepin-bot Bot merged commit bbeb382 into linuxdeepin:master May 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants