fix: remove top padding when title is empty#624
Conversation
1. Set topPadding to 0 when the dialog title is empty string 2. Apply default contentVMargin only when a title is present 3. Fix visual alignment issue for dialogs without titles Log: Hide top padding for title-less dialogs to fix layout fix: 无标题时移除顶部内边距 1. 当对话框标题为空时,将 topPadding 设为 0 2. 仅在有标题时应用默认的 contentVMargin 3. 修复无标题对话框的视觉对齐问题 Log: 无标题对话框隐藏顶部内边距以修复布局 PMS: BUG-362237
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts dialog window padding so that dialogs without a title have no top padding and keep the default vertical margin only when a title is present, fixing visual alignment issues. Flow diagram for topPadding logic in DialogWindowflowchart TD
A[DialogWindow created or title changed] --> B{title === ""}
B -- Yes --> C[Set topPadding = 0]
B -- No --> D[Set topPadding = DS.Style.dialogWindow.contentVMargin]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Log: Hide top padding for title-less dialogs to fix layout
fix: 无标题时移除顶部内边距
Log: 无标题对话框隐藏顶部内边距以修复布局
PMS: BUG-362237
Summary by Sourcery
Bug Fixes: