Skip to content

chore: update changelog to 6.7.43#748

Open
mhduiy wants to merge 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-6.7.43
Open

chore: update changelog to 6.7.43#748
mhduiy wants to merge 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-6.7.43

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented Jun 4, 2026

更新说明

自动更新 changelog 到版本 6.7.43

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 6.7.43
  • 目标分支: master

Summary by Sourcery

Update the Debian changelog metadata to reflect release version 6.7.43.

update changelog to 6.7.43

Log: update changelog to 6.7.43
@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian changelog entry to reflect the new 6.7.43 release targeting master, with no code or behavior changes.

File-Level Changes

Change Details Files
Bump Debian changelog metadata to version 6.7.43.
  • Add or update the top changelog stanza for version 6.7.43.
  • Ensure the distribution, date, and maintainer fields (if present) match project conventions for a new release entry.
  • Confirm that the new entry targets the master branch as the release baseline.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

deepin pr auto review

你好!我是CodeGeeX。我已经仔细审查了你提供的 Git Diff 输入。

审查概述

本次提交的变更仅涉及 debian/changelog 文件的修改,用于记录版本 6.7.43 的发布日志。变更内容是添加了一条新的更新日志:"fix: prevent IME from activating when echo mode is Normal"(修复:当回显模式为 Normal 时阻止输入法激活)。

由于本次 Diff 仅包含打包/发布日志的变更,不包含实际的 C++/QML 代码逻辑,因此我无法直接对语法逻辑、代码性能和代码安全性进行评估。但是,基于这条 Commit Message 所描述的修复内容,我可以为你提供关于该修复逻辑本身的深度审查和改进建议。


针对 "prevent IME from activating when echo mode is Normal" 的逻辑审查与建议

通常,这类修复出现在密码输入框(如 QLineEditechoMode 设置为 PasswordNoEcho)的处理中。正常逻辑下,当输入框处于密码模式时,应该禁用输入法(IME)以防止密码被明文记录或泄露;而当回显模式为 Normal 时,输入法应该正常工作。

如果你的代码逻辑是“当 echoModeNormal 时阻止 IME 激活”,这极有可能是一个逻辑错误。以下是我对可能出现的代码情况的审查意见:

1. 语法与逻辑

  • 潜在逻辑反转:如果修复代码类似于 if (echoMode == Normal) { setImeEnabled(false); },这是错误的。正确的逻辑应该是仅在密码模式下禁用输入法,即 if (echoMode == Password || echoMode == NoEcho) { setImeEnabled(false); }
  • 状态切换遗漏:如果在控件的生命周期内 echoMode 动态发生变化(例如用户点击“显示密码”勾选框),代码是否正确处理了 IME 状态的恢复?如果在切换回 Normal 模式时没有重新激活 IME,会导致普通输入框无法使用输入法。

2. 代码质量

  • 平台兼容性:在 Qt 中,控制输入法通常使用 setAttribute(Qt::WA_InputMethodEnabled, false)。请确保该属性在 Wayland 和 X11 平台下均能按预期工作,因为 DTK (Deepin Tool Kit) 需要适配不同的 Linux 显示服务器。
  • 事件过滤:如果修复是通过拦截 QEvent::InputMethodQEvent::InputMethodQuery 事件来实现的,请确保在 echoModeNormal 时,事件能够正常传递,否则会导致输入法候选框无法弹出或无法输入中文。

3. 代码性能

  • 频繁刷新:如果 echoMode 属性是在 paintEvent 或高频调用的函数中进行判断的,请避免在每次绘制时都调用 setAttribute。建议在 setEchoMode 的 setter 方法中一次性处理 IME 的启用/禁用状态。

4. 代码安全

  • 密码泄露风险:如果逻辑写反了(在 Normal 模式禁用 IME,而在 Password 模式启用了 IME),这将是一个严重的安全漏洞。因为某些输入法会记录用户的按键历史和词频,启用输入法输入密码会导致密码明文泄露给输入法程序,甚至被输入法的云同步功能上传。
  • 剪贴板安全:顺便检查一下,当 echoModePassword 时,是否同时禁用了鼠标右键的“复制”功能以及 Ctrl+C 快捷键,防止密码被复制到剪贴板。

修改建议

  1. 确认逻辑正确性:请重新审查你修改的 C++ 源码,确保是“在密码模式下禁用 IME”,而不是“在 Normal 模式下禁用 IME”。Changelog 的描述可能存在歧义,建议修改为更明确的表述,例如:fix: disable IME activation when echo mode is Password or NoEcho
  2. 提供完整 Diff:如果你希望我对具体的代码实现进行语法、性能和安全的详细审查,请提供包含 .cpp.h 文件改动的 Git Diff。

如果你有相关的代码片段或完整的 Diff,欢迎补充,我将为你提供更精准的代码级审查!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

TAG Bot

TAG: 6.7.43
EXISTED: no
DISTRIBUTION: unstable

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 4, 2026

TAG Bot

New tag: 6.7.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants