fix: treeland-shortcut-manager-v2: update keybind_mode enum definition#39
fix: treeland-shortcut-manager-v2: update keybind_mode enum definition#39zccrs merged 1 commit intolinuxdeepin:masterfrom
Conversation
|
Hi @misaka18931. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
This PR updates the treeland-shortcut-manager-v2 protocol to version 2, refactoring the keybind_mode enum from a simple enumeration to a bitfield-based design. This change enables more flexible keybinding configurations, specifically allowing bindings to non-repeated key release events, addressing limitations in how treeland handles repeated key events.
Changes:
- Bumped interface version from 1 to 2
- Converted keybind_mode enum to a bitfield with "release" and "repeat" flags
- Added
sinceversion attributes to all existing protocol elements for proper version tracking - Minor whitespace cleanup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR is coupled with an update in treeland-protocols. See: linuxdeepin/treeland-protocols#39 Since treeland repeats both pressed and released key events, we should allow the client to decide whether to only listen to non-repeat key release events as well, mirroring the behavior when binding to key press events. OwO
This PR is coupled with an update in treeland-protocols. See: linuxdeepin/treeland-protocols#39 Since treeland repeats both pressed and released key events, we should allow the client to decide whether to only listen to non-repeat key release events as well, mirroring the behavior when binding to key press events.
Since treeland repeats both pressed and released key events, keybind_mode should be adjusted to allow binding to only non-repeated key release events as well.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: misaka18931, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This PR is coupled with an update in treeland-protocols. See: linuxdeepin/treeland-protocols#39 Since treeland repeats both pressed and released key events, we should allow the client to decide whether to only listen to non-repeat key release events as well, mirroring the behavior when binding to key press events.
This PR is coupled with an update in treeland-protocols. See: linuxdeepin/treeland-protocols#39 Since treeland repeats both pressed and released key events, we should allow the client to decide whether to only listen to non-repeat key release events as well, mirroring the behavior when binding to key press events.
This PR is coupled with an update in treeland-protocols. See: linuxdeepin/treeland-protocols#39 Since treeland repeats both pressed and released key events, we should allow the client to decide whether to only listen to non-repeat key release events as well, mirroring the behavior when binding to key press events.
This PR is coupled with an update in treeland-protocols. See: linuxdeepin/treeland-protocols#39 Since treeland repeats both pressed and released key events, we should allow the client to decide whether to only listen to non-repeat key release events as well, mirroring the behavior when binding to key press events. (cherry picked from commit c26e2472fb069f0552dd3d85adfe86465695e508)
Since treeland repeats both pressed and released key events, keybind_mode should be adjusted to allow binding to only non-repeated key release events as well.