Skip to content

feat: refactor treeland-personalization-manager protocol implementation#847

Merged
wineee merged 1 commit intolinuxdeepin:masterfrom
zzxyb:scanner
Apr 29, 2026
Merged

feat: refactor treeland-personalization-manager protocol implementation#847
wineee merged 1 commit intolinuxdeepin:masterfrom
zzxyb:scanner

Conversation

@zzxyb
Copy link
Copy Markdown
Collaborator

@zzxyb zzxyb commented Apr 27, 2026

Replace PersonalizationV1 with PersonalizationManagerInterfaceV1 implemented on top of QtWaylandServer generated protocol classes.

Log: refactor treeland-personalization-manager protocol implementation. Tasks:

Influence:

  1. Verify behavior for treeland-personalization-manager-v1.

@zzxyb zzxyb requested a review from wineee April 27, 2026 09:46
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @zzxyb, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the treeland-personalization-manager-v1 server-side implementation by replacing the previous handcrafted Wayland protocol implementation (PersonalizationV1) with a new PersonalizationManagerInterfaceV1 built on top of QtWaylandServer generated protocol classes.
中文:此 PR 重构了服务端 treeland-personalization-manager-v1 协议实现,用基于 QtWaylandServer 生成协议类的新 PersonalizationManagerInterfaceV1 替换了旧的手写实现(PersonalizationV1)。

Changes:

  • Replace PersonalizationV1 + custom impl layer with PersonalizationManagerInterfaceV1 using QtWaylandServer generated protocol classes.
    中文:用基于 QtWaylandServer 的新实现替换 PersonalizationV1 及其自定义 impl 层。
  • Update seat/helper integration and the personalization protocol test to use the new interface.
    中文:更新 seat/helper 集成逻辑与协议测试以使用新接口。
  • Update module build to generate protocol sources via local_qtwayland_server_protocol_treeland.
    中文:更新模块构建方式,改用 local_qtwayland_server_protocol_treeland 生成协议源码。

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/test_protocol_personalization/main.cpp Switch test to attach/find PersonalizationManagerInterfaceV1. / 测试改为挂载并查找 PersonalizationManagerInterfaceV1
src/wallpaper/wallpaperitem.cpp Remove now-unused include of old personalization manager header. / 移除旧个性化管理器头文件的无用引用。
src/seat/helper.h Replace forward decl/member from PersonalizationV1 to PersonalizationManagerInterfaceV1; remove accessor. / 将前置声明与成员从 PersonalizationV1 替换为 PersonalizationManagerInterfaceV1,并移除访问函数。
src/seat/helper.cpp Attach and use PersonalizationManagerInterfaceV1 for wallpaper darkness + window personalization attachment. / 使用 PersonalizationManagerInterfaceV1 处理壁纸深浅与窗口个性化绑定。
src/modules/personalization/personalizationmanagerinterfacev1.h Introduce new QtWaylandServer-based protocol interface + context wrappers. / 新增基于 QtWaylandServer 的协议接口与上下文封装。
src/modules/personalization/personalizationmanagerinterfacev1.cpp Implement new protocol manager and contexts; integrate wallpaper/cursor/appearance/font handling. / 实现新的协议管理器与上下文,处理壁纸/光标/外观/字体逻辑。
src/modules/personalization/personalizationmanager.h Removed old PersonalizationV1 public header. / 删除旧 PersonalizationV1 头文件。
src/modules/personalization/personalizationmanager.cpp Removed old PersonalizationV1 implementation. / 删除旧 PersonalizationV1 实现。
src/modules/personalization/impl/util.h Removed old protocol dispatch utility. / 删除旧协议分发工具。
src/modules/personalization/impl/types.h Removed old shared types header. / 删除旧共享类型头文件。
src/modules/personalization/impl/personalization_manager_impl.h Removed old custom Wayland protocol impl definitions. / 删除旧自定义 Wayland 协议实现定义。
src/modules/personalization/impl/personalization_manager_impl.cpp Removed old custom Wayland protocol impl code. / 删除旧自定义 Wayland 协议实现代码。
src/modules/personalization/impl/font_impl.h Removed old font context implementation. / 删除旧字体上下文实现。
src/modules/personalization/impl/font_impl.cpp Removed old font context implementation code. / 删除旧字体上下文实现代码。
src/modules/personalization/impl/appearance_impl.h Removed old appearance context implementation. / 删除旧外观上下文实现。
src/modules/personalization/impl/appearance_impl.cpp Removed old appearance context implementation code. / 删除旧外观上下文实现代码。
src/modules/personalization/CMakeLists.txt Switch protocol generation to local_qtwayland_server_protocol_treeland and update sources list. / 协议生成切换到 local_qtwayland_server_protocol_treeland 并更新源码列表。

Comment thread src/modules/personalization/personalizationmanagerinterfacev1.cpp
Comment thread src/modules/personalization/CMakeLists.txt
Comment thread src/modules/personalization/personalizationmanagerinterfacev1.cpp
Comment thread src/modules/personalization/personalizationmanagerinterfacev1.cpp Outdated
Comment thread src/modules/personalization/personalizationmanagerinterfacev1.cpp
Comment thread src/modules/personalization/personalizationmanagerinterfacev1.cpp Outdated
Replace PersonalizationV1 with PersonalizationManagerInterfaceV1
implemented on top of QtWaylandServer generated protocol classes.

Log: refactor treeland-personalization-manager protocol implementation.
Tasks:

Influence:
1. Verify behavior for treeland-personalization-manager-v1.
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee, zzxyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zzxyb zzxyb requested a review from zccrs April 29, 2026 02:52
@wineee wineee merged commit 45b8855 into linuxdeepin:master Apr 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants