Skip to content

fix python 3.11 collections not defined#138

Merged
lyf0601 merged 1 commit intolinuxdeepin:masterfrom
peeweep:fix-collections-not-defined
Mar 18, 2025
Merged

fix python 3.11 collections not defined#138
lyf0601 merged 1 commit intolinuxdeepin:masterfrom
peeweep:fix-collections-not-defined

Conversation

@peeweep
Copy link
Copy Markdown
Member

@peeweep peeweep commented Mar 16, 2025

Close: #137

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peeweep

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

代码审查意见:

  1. 版本兼容性

    • rawinput_wayland.py_pyautogui_wayland.py文件中,增加了对Python 3.11的支持。这是一个好的做法,因为Python 3.11已经发布并且得到了广泛使用。但是,需要确保代码在Python 3.11上能够正常运行,并且没有引入任何新的bug。
  2. 代码注释

    • 在增加对Python 3.11支持的同时,注释应该更新以反映这一变化。注释应该说明为什么需要支持Python 3.11,以及这样做的好处。
  3. 代码风格

    • 虽然代码风格没有明显的错误,但是建议检查整个项目中是否有一致的代码风格指南,并确保新添加的代码遵循这一指南。
  4. 依赖管理

    • 确保在添加对Python 3.11支持时,没有引入任何新的依赖,并且所有依赖都是最新的,并且与Python 3.11兼容。
  5. 测试

    • 在添加对新Python版本的支持后,应该运行所有测试用例,以确保代码在Python 3.11上仍然能够正常工作。如果可能的话,应该编写一些特定的测试用例来测试Python 3.11上的新功能。
  6. 文档

    • 如果这个更改会影响项目的文档或用户指南,应该更新相应的文档以反映这一变化。

总体来说,这个提交是一个小的改动,但是需要确保所有相关的方面都被正确处理,以避免引入任何问题。

@wangp-h
Copy link
Copy Markdown
Contributor

wangp-h commented Mar 18, 2025

/lgtm

@lyf0601 lyf0601 merged commit 8c06609 into linuxdeepin:master Mar 18, 2025
2 of 3 checks passed
@peeweep peeweep deleted the fix-collections-not-defined branch March 18, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] python 3.11 运行 sniff 报错 name 'collections' is not defined

4 participants