Merged
Conversation
This was the original intention of commit 6a8984b on March 2011. At that moment, the default value for `cc_licensed` on nodes where `false` and we only needed to set it to true if the diary license where the CC one. Although, on December 2012, we changed the default value to `false` with commit 7c6058f and it broke the diary converter algorithm. This fix allows to be not any more linked to the current default value on the `cc_licensed` node as we always enfoce the new news to have the same license.
Oumph
reviewed
Jan 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is the new PR created from #318 with only contain new behaviour for the diary converter
The diary to news converter creates always news with creative common license.
Even if the original author has removed the creative common license, the news created from it will be creative common licensed.
See commit 2a9c0a3 to understand why this fix is needed.
See linked suivi request.