Update containerd vendor #3577
Merged
Update containerd vendor #3577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes arm64 mac Signed-off-by: Justin Cormack <justin@specialbusservice.com>
Collaborator
|
Will this conflict with #3575 ? |
Member
Author
|
Yes. Needs a later containerd... |
Collaborator
|
I don't see that as a major issue. But we don't know until we try. |
deitch
approved these changes
Nov 26, 2020
Collaborator
|
Approved. As soon as you have this merged in, I'll rebase the other one, test it, and you can approve that one. |
Member
Author
|
merged @deitch |
Collaborator
|
Does lkt now build a binary for darwin-arm64, or is that still dependent on having go compiler for it? When done add it to our testing matrix? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes arm64 mac, just by updating containerd vendoring.
Signed-off-by: Justin Cormack justin@specialbusservice.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)