perf(processor): reduce la2aHighCrestMaxDeficit from 8.0 to 6.0 dB

[flexiondotorg]

Increase severity scaling for moderate deficits to ensure they receive more aggressive parameter overrides. Adjusts high-crest override strategy to better handle cases like 2.6 dB deficit, where the original 8.0 factor was overly lenient. Updates all test assertions to reflect new severity values.

Checklist

• I have performed a self-review of my code
• I have tested my changes and confirmed there are no regressions

[cubic-dev-ai]

2 issues found across 3 files

Confidence score: 5/5

• This PR looks low risk to merge because both findings are low-severity documentation mismatches (2/10) with high confidence, and neither indicates functional or behavioral regressions.
• In internal/processor/adaptive.go, the LA2AHighCrestSeverity comment still says deficit / 8.0 even though logic now uses 4 dB scaling, which could mislead future maintenance if left unchanged.
• In internal/processor/adaptive_test.go, the floor comment still describes the old 8 dB scale while assertions enforce 4 dB-scale floors, creating explanation drift but not a runtime bug.
• Pay close attention to internal/processor/adaptive.go, internal/processor/adaptive_test.go - align stale comments with the updated 4 dB scaling behavior.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/processor/adaptive.go">

<violation number="1" location="internal/processor/adaptive.go:273">
P3: Update the `LA2AHighCrestSeverity` diagnostic comment to match the new 4 dB scaling; it still documents `deficit / 8.0`.</violation>
</file>

<file name="internal/processor/adaptive_test.go">

<violation number="1" location="internal/processor/adaptive_test.go:2457">
P3: The nearby floor comment still documents the old 8 dB scale, but these updated assertions now enforce the stronger 4 dB-scale floors. Update the comment so the test's explanation matches what it actually verifies.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

2 issues found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/processor/adaptive.go">

<violation number="1" location="internal/processor/adaptive.go:273">
P1: This change makes moderate high-crest deficits less aggressive, opposite to the intended severity increase.</violation>
</file>

<file name="docs/FilterCompressor-Teletronix LA-2A.md">

<violation number="1" location="docs/FilterCompressor-Teletronix LA-2A.md:62">
P1: This sets the high-crest severity ramp to 6 dB, but the PR’s stated change is 8 dB → 4 dB. Moderate deficits like 2.6 dB will still be under-scaled.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Requires human review: Auto-approval blocked by 2 unresolved issues from previous reviews.}