Skip to content

fix(processor): isolate loudnorm capture to graph finalisation#84

Merged
flexiondotorg merged 1 commit intomainfrom
loudnorm
May 4, 2026
Merged

fix(processor): isolate loudnorm capture to graph finalisation#84
flexiondotorg merged 1 commit intomainfrom
loudnorm

Conversation

@flexiondotorg
Copy link
Copy Markdown
Contributor

  • Capture loudnorm JSON only while freeing the filter graph, where FFmpeg emits it.
  • Avoid starting process-global log capture until graph teardown in Pass 3 and Pass 4.
  • Tighten error handling so setup, loop, and encoder failures do not start capture.
  • Expand tests for malformed JSON, missing JSON, serialised capture, and clean-up order.

- Capture loudnorm JSON only while freeing the filter graph, where
  FFmpeg emits it.
- Avoid starting process-global log capture until graph teardown in Pass
  3 and Pass 4.
- Tighten error handling so setup, loop, and encoder failures do not
  start capture.
- Expand tests for malformed JSON, missing JSON, serialised capture, and
  clean-up order.

Signed-off-by: Martin Wimpress <code@wimpress.io>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Refactors global FFmpeg log capture and graph finalization logic; touches process-wide state and core audio processing paths.

@flexiondotorg flexiondotorg merged commit 0f76324 into main May 4, 2026
16 checks passed
@flexiondotorg flexiondotorg deleted the loudnorm branch May 4, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant