fix(processor): isolate loudnorm capture to graph finalisation#84
Merged
flexiondotorg merged 1 commit intomainfrom May 4, 2026
Merged
fix(processor): isolate loudnorm capture to graph finalisation#84flexiondotorg merged 1 commit intomainfrom
flexiondotorg merged 1 commit intomainfrom
Conversation
Contributor
flexiondotorg
commented
May 4, 2026
- Capture loudnorm JSON only while freeing the filter graph, where FFmpeg emits it.
- Avoid starting process-global log capture until graph teardown in Pass 3 and Pass 4.
- Tighten error handling so setup, loop, and encoder failures do not start capture.
- Expand tests for malformed JSON, missing JSON, serialised capture, and clean-up order.
- Capture loudnorm JSON only while freeing the filter graph, where FFmpeg emits it. - Avoid starting process-global log capture until graph teardown in Pass 3 and Pass 4. - Tighten error handling so setup, loop, and encoder failures do not start capture. - Expand tests for malformed JSON, missing JSON, serialised capture, and clean-up order. Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Refactors global FFmpeg log capture and graph finalization logic; touches process-wide state and core audio processing paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.