refactor(processor): use progress update events for callbacks#89
Merged
flexiondotorg merged 1 commit intomainfrom May 5, 2026
Merged
refactor(processor): use progress update events for callbacks#89flexiondotorg merged 1 commit intomainfrom
flexiondotorg merged 1 commit intomainfrom
Conversation
- Add `ProgressUpdate` and `ProgressCallback` to carry progress data in one value - Move UI message mapping into `cmd/jivetalking/main.go` - Remove the temporary legacy adapter and update processor call sites - Add boundary tests for callback shape and progress event fields Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 9 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This is a non-trivial refactor that changes function signatures across 9 files, including core processor functions (AnalyzeAudio, ProcessAudio, ApplyNormalisation). The blast radius is moderate; a bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProgressUpdateandProgressCallbackto carry progress data in one valuecmd/jivetalking/main.go