Skip to content

GWL: Fix thumbnail preview issue when window fade-out setting is non-zero#10263

Merged
clefebvre merged 1 commit intolinuxmint:masterfrom
ronyala:bugfix/GWL-thumbnail-preview
Nov 8, 2021
Merged

GWL: Fix thumbnail preview issue when window fade-out setting is non-zero#10263
clefebvre merged 1 commit intolinuxmint:masterfrom
ronyala:bugfix/GWL-thumbnail-preview

Conversation

@ronyala
Copy link
Copy Markdown
Contributor

@ronyala ronyala commented Aug 11, 2021

In order to have fade-out animations, multiple preview overlays are needed at the same time.
The existing code did not handle this, instead not creating a new overlay and not showing a window preview if an existing overlay was fading out.

I did not find any existing issues that were reported about this.
I also did some related code cleanup.

In order to have fade-out animations, multiple preview overlays are needed at the same time.
The existing code did not handle this, instead not creating a new overlay and not showing a window preview if an existing overlay was fading-out.
@clefebvre
Copy link
Copy Markdown
Member

@ronyala can you describe how to reproduce the issue?

@clefebvre clefebvre self-assigned this Nov 8, 2021
@ronyala
Copy link
Copy Markdown
Contributor Author

ronyala commented Nov 8, 2021

@clefebvre

  1. Set the window fade-out time in grouped-window-list to a value greater than 0 (Ex. 150ms).
  2. Open multiple windows of the same program, it's most apparent with at least 4-5 windows
  3. Hide the existing windows behind a different program so it's easier to see (Ex. multiple nemo windows hidden behind a firefox window)
  4. Hover over the window thumbnails in gwl, at least half of them will not show the corresponding window (new overlays/previews are not created while there is an existing overlay)

@clefebvre
Copy link
Copy Markdown
Member

Perfect, I can reproduce both the issue and the fix.

@clefebvre clefebvre merged commit 642137c into linuxmint:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants