Skip to content

Menu applet: Improve keyboard navigation with RTL layout #10376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clefebvre merged 1 commit into from
Nov 8, 2021
Merged

Menu applet: Improve keyboard navigation with RTL layout #10376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions files/usr/share/cinnamon/applets/menu@cinnamon.org/applet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1727,6 +1727,16 @@ class CinnamonMenuApplet extends Applet.TextIconApplet {
let keyCode = event.get_key_code();
let modifierState = Cinnamon.get_event_state(event);

/* Accounts for mirrored RTL layout.
Switches between left/right key presses */
if(St.Widget.get_default_direction() === St.TextDirection.RTL) {
if(symbol === Clutter.KEY_Right) {
symbol = Clutter.KEY_Left;
} else if(symbol === Clutter.KEY_Left) {
symbol = Clutter.KEY_Right;
}
}

/* check for a keybinding and quit early, otherwise we get a double hit
of the keybinding callback */
let action = global.display.get_keybinding_action(keyCode, modifierState);
Expand Down