Upstream: Apply closure patches#55
Merged
clefebvre merged 2 commits intolinuxmint:masterfrom Oct 21, 2017
jaszhix:closure-patches
Merged
Upstream: Apply closure patches#55clefebvre merged 2 commits intolinuxmint:masterfrom jaszhix:closure-patches
clefebvre merged 2 commits intolinuxmint:masterfrom
jaszhix:closure-patches
Conversation
This turned out to cause a lot of problems; it has been responsible for almost all of the crashes in gnome-shell since 1.48. We revert back to the original code modulo a few improvements that have been made along the way. This state at least does not crash in the test suite, although it is definitely not correct since it breaks SpiderMonkey's garbage collector pre barrier verification mode (the reason the change was made in the first place.) That still must be fixed using a different approach. This partially reverts commits [41b78ae], [db3e387], [bace908], [9eb4a2b], [2593d3d], and [334ba96]. https://bugzilla.gnome.org/show_bug.cgi?id=786668 https://bugzilla.gnome.org/show_bug.cgi?id=785657
It's not possible to stop tracing an object in the middle of GC. However, by using JS::ExposeObjectToActiveJS(), it is possible to mark an object as reachable for the duration of one GC. This is exactly what we need for closures, to keep the closure's callable object from disappearing while GC is going on. https://bugzilla.gnome.org/show_bug.cgi?id=786668 https://bugzilla.gnome.org/show_bug.cgi?id=785657
This was referenced Oct 19, 2017
Member
|
Bug report: #56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not seeing any regressions in stability or performance with these so far.