fix: sync fullscreen state with WM and move GTK calls to main thread#415
Open
MauricioBarrientos wants to merge 1 commit into
Open
Conversation
- Fixes linuxmint#385: Connect window-state-event to sync self.fullscreen with the actual WM state. In Hyprland/Wayland the WM can toggle fullscreen independently, causing desync. full_screen_mode() now reads gdk_window.get_state() instead of blindly toggling the internal flag. - Fixes linuxmint#409: Remove direct GTK calls from @async_function threads. Move info_menu_item.set_sensitive(False) into before_play() which runs via @idle_function on the main thread. Add set_cursor() helper decorated with @idle_function so Xtream cursor changes in reload() are marshaled to the main GTK thread, preventing X11 BadRequest errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Fullscreen Exit #385: Connect window-state-event to sync self.fullscreen with the actual WM state. In Hyprland/Wayland the WM can toggle fullscreen independently, causing desync. full_screen_mode() now reads gdk_window.get_state() instead of blindly toggling the internal flag.
Fixes GTK/X11 crashes from GTK calls inside @async_function worker threads #409: Remove direct GTK calls from @async_function threads. Move info_menu_item.set_sensitive(False) into before_play() which runs via @idle_function on the main thread. Add set_cursor() helper decorated with @idle_function so Xtream cursor changes in reload() are marshaled to the main GTK thread, preventing X11 BadRequest errors.