Skip to content

mintinstall: Prefer system theme icons on flatpak packages #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elch01 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

mintinstall: Prefer system theme icons on flatpak packages #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions usr/lib/linuxmint/mintinstall/mintinstall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,11 @@ def repopulate_tile(self):
self.icon.destroy()

icon_string = self.pkginfo.get_icon(imaging.FEATURED_ICON_SIZE)

# Check for flatpak names and if there is a icon present in the installed icon theme prefer that one
if self.pkginfo.pkg_hash.startswith("fp:") and Gtk.IconTheme.get_default().has_icon(self.pkginfo.name):
icon_string = self.pkginfo.name

if not icon_string:
icon_string = imaging.FALLBACK_PACKAGE_ICON_PATH
self.icon = imaging.get_icon(icon_string, imaging.FEATURED_ICON_SIZE)
Expand Down Expand Up @@ -2717,6 +2722,11 @@ def show_package(self, pkginfo, previous_page):
# Set source-agnostic things

icon_string = self.get_application_icon_string(pkginfo, imaging.DETAILS_ICON_SIZE)

# Check if package is a flatpak if so prefer themed icon over downloaded one
if is_flatpak and Gtk.IconTheme.get_default().has_icon(pkginfo.name):
icon_string = pkginfo.name

self.detail_view_icon.set_icon_string(icon_string)

self.package_type_store.clear()
Expand Down