Skip to content

[1.8] Allow cycling through workspaces#36

Merged
clefebvre merged 3 commits intolinuxmint:masterfrom
AlbertJP:workspace-cycle
Nov 21, 2012
Merged

[1.8] Allow cycling through workspaces#36
clefebvre merged 3 commits intolinuxmint:masterfrom
AlbertJP:workspace-cycle

Conversation

@AlbertJP
Copy link
Contributor

To add this option to cinnamon settings I have also done a pull request at Cinnamon:

@dalcde
Copy link
Contributor

dalcde commented Sep 14, 2012

@AlbertJP Can you update debian/libmuffin0.symbols as well? It doesn't build with dpkg-buildpackage otherwise.

@dalcde
Copy link
Contributor

dalcde commented Sep 15, 2012

Is the requirement of restarting cinnamon a bug?

@AlbertJP
Copy link
Contributor Author

@dalcde If you don't want to restart cinnamon, it would require having muffin listen to changes in gsettings. It already does so for the edge-tiling key so maybe it can be done as well for the workspace-cycle key.

@dalcde
Copy link
Contributor

dalcde commented Sep 15, 2012

I think muffin listens to changes of all keys.

pref.c line 833-834:

settings = g_settings_new (SCHEMA_MUFFIN);
g_signal_connect (settings, "changed", G_CALLBACK (settings_changed), NULL);

@AlbertJP
Copy link
Contributor Author

@dalcde I was unaware that it already listened to that. Actually it doesn't require restarting Cinnamon at all.
I have removed the text "requires Cinnamon restart": AlbertJP/Cinnamon@2457f6a

@autarkper
Copy link
Contributor

As noted by @dalcde some time ago, this will still not build with dpkg-buildpackage.

@AlbertJP
Copy link
Contributor Author

@dalcde @autarkper I've rebased on current master and added the symbol.

clefebvre added a commit that referenced this pull request Nov 21, 2012
[1.8] Allow cycling through workspaces
@clefebvre clefebvre merged commit 3973116 into linuxmint:master Nov 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants