Found a crash in nemo

[kdmenk]

Distribution

Linux Mint cinemon, but cloned nemo master

Package version

nemo master

Frequency

Always

Bug description

In the file src/nemo-tree-sidebar.c i found a bug in the callback registration/deregistration:

See in function fm_tree_view_init at line 1718:

g_signal_connect_swapped (**nemo_preferences**,
			  "changed::" NEMO_PREFERENCES_TREE_SHOW_ONLY_DIRECTORIES,
			  G_CALLBACK (filtering_changed_callback), view);

g_signal_connect_swapped (nemo_preferences,
              "changed::" NEMO_PREFERENCES_SORT_DIRECTORIES_FIRST,
              G_CALLBACK (sort_directories_first_changed_callback), view);
              
g_signal_connect_swapped (nemo_preferences,
              "changed::" NEMO_PREFERENCES_SORT_FAVORITES_FIRST,
              G_CALLBACK (sort_favorites_first_changed_callback), view);

And in same file below function fm_tree_view_dispose line 1817:

g_signal_handlers_disconnect_by_func (**nemo_preferences**,
				      G_CALLBACK(filtering_changed_callback),
				      view);
g_signal_handlers_disconnect_by_func (**nemo_preferences**,
                      G_CALLBACK(sort_directories_first_changed_callback),
                      view);
g_signal_handlers_disconnect_by_func (**nemo_preferences**,
                      G_CALLBACK(sort_favorites_first_changed_callback),
                      view);

You will find an incosistent disconnect with nemo_preferences and nemo_tree_sidebar_preferences!
This leeds to dangling event registartions which brings a crash when usung updates and toggle between Places and Treeview

Above is critical...
I found also some memory leeks not includes in this message...

Steps to reproduce

Toggle between Show Places and Show Treeview , while changing "sort folder before files" wich fires an related event...

Expected behavior

Nemo will crash

Additional information

I Think the code above helps to fix the bug already

As I mentioned, I found some not freed memory too.

[Fantu]

Hi, if you want to contribute, even only with small fixes, I suggest to open PR

[kdmenk]

Hi, yes would be great. :-)
I can differ between real bug fixes and new features.
By the way, where is the right place to discuss a new feature with a file TreeView in the side bar?
Regards
Klaus

[Fantu]

Split bugfixes and features in different PR is good.
I saw you already opened a discussion about the new feature: https://github.com/orgs/linuxmint/discussions/1169
if you are also doing it in practice you can also open a PR (draft if incomplete), you can also add [RFC] if you want request for comments.
If new features are long and complex things, however, I would advise you to ask @clefebvre and @mtwebster first if it is something that could be acceptable so as not to risk losing too much.

[kdmenk]

Yes, that's great. I will contact both about the new feature idea.
Today, I think I got a status, which is already usable to check for the usability.

But first I will open a PR for the bug I've found.
Thanks
Klaus

[Fantu]

Have you looked the latest commits that did @mtwebster ? Seems related to the bugs you reported

[kdmenk]

I think, I need the permission to open an PR correct?
I guess I do not have.

[Fantu]

For open a PR don't need permission in opensource projects like this, the permission is needed to be able to merge it, PR are reviewed and merged (if accepted) by linuxmint team.

[kdmenk]

the Commit d0d9591 fixes exactly the above issue. I already checked it and it is fixed now in the head release. :-)
I close this bug report now. It is fixed.

Thanks
Klaus