Add tracker support#2334
Merged
mtwebster merged 2 commits intolinuxmint:masterfrom May 12, 2020
J08nY:feature/add-tracker-support
Merged
Add tracker support#2334mtwebster merged 2 commits intolinuxmint:masterfrom J08nY:feature/add-tracker-support
mtwebster merged 2 commits intolinuxmint:masterfrom
J08nY:feature/add-tracker-support
Conversation
This reverts commit 5db7a44.
Member
|
-1 to this request, it doesn't address any of the previous tracker issues . |
Contributor
Author
I found #1551 that seems related, are there any other issues that you know of? Will look at this one. |
Contributor
Author
|
I was not able to reproduce #1551, I built this branch and tested the provided example with tracker both on and off and it did not trigger the segfault. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts 5db7a44 and applies a patch to add support for
tracker-2taken from #2065There is really no reason to drop support for this when there is a patch that applies cleanly and keeps it usable with current versions of tracker.