"View TimeShift Logs" button doesn't work

[cycion]

Describe the bug
A small issue with certain file manager (in this case: Nautilus) where the "View TimeShift Logs" button doesn't open anything

To Reproduce
Steps to reproduce the behavior:

1. Open the app
2. Click on Menu, then View TimeShift Logs
3. Nothing happens (Yields error ** (org.gnome.Nautilus:581180): WARNING **: 15:51:47.286: Running as root is not supported. Consider running nautilus admin:/// instead. when run through terminal)

Expected behavior
A file manager window open with the error log.

System:

• Linux Distribution Name and Version: Arch Linux
• Desktop: GNOME 49.4
• Timeshift Version: 25.12.4
• Timeshift Mode [btrfs/rsync?]: btrfs
• Display Server: Wayland
• File manager: Nautilus

[cycion]

timeshift/src/Utility/TeeJee.System.vala

Lines 100 to 144 in b2151aa

	public bool exo_open_folder (string dir_path, bool xdg_open_try_first = true){
	/* Tries to open the given directory in a file manager */
	/*
	xdg-open is a desktop-independent tool for configuring the default applications of a user.
	Inside a desktop environment (e.g. GNOME, KDE, Xfce), xdg-open simply passes the arguments
	to that desktop environment's file-opener application (gvfs-open, kde-open, exo-open, respectively).
	We will first try using xdg-open and then check for specific file managers if it fails.
	*/
	bool xdgAvailable = cmd_exists("xdg-open");
	string escaped_dir_path = escape_single_quote(dir_path);
	int status = -1;
	if (xdg_open_try_first && xdgAvailable){
	//try using xdg-open
	string cmd = "xdg-open '%s'".printf(escaped_dir_path);
	status = exec_script_async (cmd);
	return (status == 0);
	}
	foreach(string app_name in
	new string[]{ "nemo", "nautilus", "thunar", "io.elementary.files", "pantheon-files", "marlin", "dolphin" }){
	if(!cmd_exists(app_name)) {
	continue;
	}
	string cmd = "%s '%s'".printf(app_name, escaped_dir_path);
	status = exec_script_async (cmd);
	if(status == 0) {
	return true;
	}
	}
	if (!xdg_open_try_first && xdgAvailable){
	//try using xdg-open
	string cmd = "xdg-open '%s'".printf(escaped_dir_path);
	status = exec_script_async (cmd);
	return (status == 0);
	}
	return false;
	}

Because Timeshift must be run as root, the file manager will also get ran as root (which is highly discouraged), leading to Nautilus failing to open. The app should drop privilege before opening a file manager.

[ygerlach]

I bet browsing snapshots does not work for you as well?

[cycion]

yes, browsing files in snapshot also doesn't work.

[ygerlach]

Feel free to try the branch i proposed in #518