Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Feature Request: Support environment variable for version #12

@derekmurawsky

Description

@derekmurawsky

Expected Behavior

Set a DOCKER_COMPOSE_VERSION environment variable and have the run script use it.
If the environment variable doesn't exist, have it default to latest.

Current Behavior

In order to change versions you have to edit the run script itself.

Thoughts

Keeping config in the environment is a normal and accepted pattern. Having version pinning is also a normal/desired feature from a CICD perspective. Having to edit the script to run docker-compose in a specific version seems like an anti-pattern.

It think this change is as easy as changing

VERSION="latest" # can be set to a specific version tag from docker hub, such as "1.25.5", or "alpine"
IMAGE="linuxserver/docker-compose:$VERSION"

to

DOCKER_COMPOSE_VERSION:="latest" # can be set to a specific version tag from docker hub, such as "1.25.5", or "alpine"
IMAGE="linuxserver/docker-compose:$DOCKER_COMPOSE_VERSION"

I would be happy to put in a PR if this is something others would like. Perhaps a different Variable name to prevent confusion between the docker version and the container version?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions