Skip to content

[FEAT] Modify NO_FULL behaviour to only affect main application window #121

@c360e5f1

Description

@c360e5f1

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Hello!

Thanks for making and maintaining this project. I've been using it extensively and been really happy with it.

One feature that I would like to suggest is a modification to the NO_FULL option flag. When this is enabled, applications automatically maximize to use the full size of the viewport in the browser, which is perfect. When used as a PWA, the applications will also automatically expand and use the full size of the PWA's viewport. Great! This is exactly what we want!

Reason for change

The problem comes when the application itself produces pop-ups or dialog boxes. The first time I encountered this was using the FreeCAD Selkies image. When using the application, dialog boxes will regularly pop up asking for input, such as to put in constraints or to set dimensions. When NO_FULL is true, the dialog box also gets maximized to take up the full size of the viewport, adding an additional step to the workflow for the application to un-maximize the dialog box to see what I'm doing.

However, when NO_FULL is not set or set to false, the application isn't maximized automatically (expected), and dialog boxes and pop up boxes aren't taking up the full screen (yay!). However, if this is used in conjunction with NO_DECOR, there's no longer a way to manually maximize the main application window and the viewport has a lot of wasted space.

Proposed code change

This is just a minor issue, but my suggested feature improvement is the following:

  • Modify the NO_FULL behaviour or add a new flag NO_POPUP_FULL or NO_DIALOGBOX_FULL so it only affects new windows or application pop-up boxes or dialog boxes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions