Add php7-dom extension #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes plugins using dom methods, which may expect it because php by default is compiled with dom methods on. Fixes cosmocode/dokuwiki-template-sprintdoc#65
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Collaborator
|
I am a bot, here are the test results for this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes plugins using dom methods, which may expect it because normal php by default is compiled with dom methods on.
In practice this fixes minor issues in the popular sprintdoc template.
Benefits of this PR and context:
Fixes cosmocode/dokuwiki-template-sprintdoc#65
How Has This Been Tested?
Only tested and validated on an x86_64 machine.
Source / References:
sprintdoc: https://www.dokuwiki.org/template:sprintdoc
missing function: https://www.php.net/manual/en/function.dom-import-simplexml.php