Conversation
Contributor
|
I am a bot, here are the test results for this PR:
|
aptalca
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This enables support for SBOM and Provenance manifests to be included with builds.
Notable change to the process is to push the buildcache image at the end of the builds for all arches to all registries, and then tag them later, rather than pushing after the CI tests. This is because you can't pull and repush attestations.
Requires all build agents to be at least 537157a0-ls94
Benefits of this PR and context:
How Has This Been Tested?
SBOM-enabled builds via https://github.com/linuxserver/docker-adguardhome-sync/tree/sbom-test
See
docker buildx imagetools inspect ghcr.io/linuxserver/lsiodev-adguardhome-sync:latest --format '{{ json (index .SBOM "linux/amd64").SPDX }}' | morefor the pushed SBOM (for amd64).Or if you just want a quick list of packages + versions similar to our package_version.txt:
docker buildx imagetools inspect ghcr.io/linuxserver/lsiodev-adguardhome-sync:latest --format '{{ range (index .SBOM "linux/amd64").SPDX.packages }}{{ .name }}@{{ .versionInfo }}{{ println }}{{ end }}'Provenance is supported by the same changes but needs to be decided if we care about enabling it.
Source / References:
https://docs.docker.com/build/metadata/attestations/slsa-provenance/
https://docs.docker.com/build/metadata/attestations/sbom/