Conversation
quietsy
approved these changes
Feb 9, 2025
Contributor
|
I am a bot, here are the test results for this PR:
|
Roxedus
approved these changes
Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Prune all images after selective system prune to avoid CI test image buildup
Benefits of this PR and context:
In #321 we stopped doing an
allsystem prune because it removes the buildx container, which stops us from pruning its internal image storage and lead to the disk filling up.But on the x86 hosts we
loadbuilt images into the "host" (build agent) image store for CI testing and subsequent pushes, and these weren't getting cleaned up.How Has This Been Tested?
Source / References: