Replace Travis with GHA #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. Confirmed with #89 that PRs will build but not push. |
|
Also confirmed pushing works https://github.com/nemchik/docker-mods/runs/1303687783 |
|
This looks great. We should probably also update the readme on the master branch with gha instead of travis after this is merged |
|
|
aptalca
approved these changes
Oct 25, 2020
aptalca
approved these changes
Oct 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Travis with GitHub Actions workflow.
Requires we set secrets in the repo setting https://github.com/linuxserver/docker-mods/settings/secrets for DOCKERPASS and DOCKERUSER (same as how it's setup in Travis).
Users only need to edit the 2 environment variables
Image push only happens if the branch matches the variables (so branches in development would not push). Build happens on all branches (so we can confirm build is successful without pushing images).
For now, new images should use this. Long term goal would be to replace Travis with GHA on all existing branches.