Skip to content

Fix uploading large files#481

Merged
quietsy merged 1 commit intodevelopfrom
fix-large-files-develop
Jan 9, 2025
Merged

Fix uploading large files#481
quietsy merged 1 commit intodevelopfrom
fix-large-files-develop

Conversation

@quietsy
Copy link
Copy Markdown
Member

@quietsy quietsy commented Oct 25, 2024

Fix uploading large files which is a very common support issue

@quietsy quietsy requested a review from a team October 25, 2024 13:45
@drizuid
Copy link
Copy Markdown
Member

drizuid commented Oct 25, 2024

As per the nextcloud documentation, this should not be done as it can break low memory systems; user should read the documentation, understand the risks, and update accordingly. The default we use is the recommended official default from nextcloud.

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-edec5770-dev-115ac77edb2ea60a075e498abbe93753741e982f-pr-481/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-edec5770-dev-115ac77edb2ea60a075e498abbe93753741e982f-pr-481/shellcheck-result.xml

Tag Passed
amd64-develop-30.0.1rc2-pkg-edec5770-dev-115ac77edb2ea60a075e498abbe93753741e982f-pr-481
arm64v8-develop-30.0.1rc2-pkg-edec5770-dev-115ac77edb2ea60a075e498abbe93753741e982f-pr-481

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-edec5770-dev-94dff3871a6eff8d67d86e8b8dc99caea141e30c-pr-481/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-edec5770-dev-94dff3871a6eff8d67d86e8b8dc99caea141e30c-pr-481/shellcheck-result.xml

Tag Passed
amd64-develop-30.0.1rc2-pkg-edec5770-dev-94dff3871a6eff8d67d86e8b8dc99caea141e30c-pr-481
arm64v8-develop-30.0.1rc2-pkg-edec5770-dev-94dff3871a6eff8d67d86e8b8dc99caea141e30c-pr-481

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-edec5770-dev-1572ee2283d31dac7e200c1fcb37d4f017832051-pr-481/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-edec5770-dev-1572ee2283d31dac7e200c1fcb37d4f017832051-pr-481/shellcheck-result.xml

Tag Passed
amd64-develop-30.0.1rc2-pkg-edec5770-dev-1572ee2283d31dac7e200c1fcb37d4f017832051-pr-481
arm64v8-develop-30.0.1rc2-pkg-edec5770-dev-1572ee2283d31dac7e200c1fcb37d4f017832051-pr-481

@nemchik
Copy link
Copy Markdown
Member

nemchik commented Oct 25, 2024

Ref: https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html

Note that some of the defaults you're proposing here are significantly higher than the values NC's own documentation provides as examples for increasing the values.

@quietsy
Copy link
Copy Markdown
Member Author

quietsy commented Oct 25, 2024

Ref: https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html

Note that some of the defaults you're proposing here are significantly higher than the values NC's own documentation provides as examples for increasing the values.

Yup, I don't see a downside, the real limits are user quotas and disk space

@nemchik
Copy link
Copy Markdown
Member

nemchik commented Oct 25, 2024

Ref: https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html
Note that some of the defaults you're proposing here are significantly higher than the values NC's own documentation provides as examples for increasing the values.

Yup, I don't see a downside, the real limits are user quotas and disk space

If we're confident that there are no concerns with lower resource devices then I'm ok with these changes. Main reason we stuck with what is in NC's docs is because the thought was that lower powered devices might not love the higher limits.

@quietsy
Copy link
Copy Markdown
Member Author

quietsy commented Oct 26, 2024

If we're confident that there are no concerns with lower resource devices then I'm ok with these changes. Main reason we stuck with what is in NC's docs is because the thought was that lower powered devices might not love the higher limits.

I've tested it on a container with a 512mb ram limit and everything still works fine, even uploading huge files.
I'll push it only to develop for a few weeks and continue to test it on my prod instance for that duration.

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-57bf3370-dev-a99d97234611d4b0d7d4c4a0ba3130431dcd489e-pr-481/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.1rc2-pkg-57bf3370-dev-a99d97234611d4b0d7d4c4a0ba3130431dcd489e-pr-481/shellcheck-result.xml

Tag Passed
amd64-develop-30.0.1rc2-pkg-57bf3370-dev-a99d97234611d4b0d7d4c4a0ba3130431dcd489e-pr-481
arm64v8-develop-30.0.1rc2-pkg-57bf3370-dev-a99d97234611d4b0d7d4c4a0ba3130431dcd489e-pr-481

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.2rc2-pkg-838c155f-dev-f3c7a8960acefcf3cdd6a63dca3b8a5f1c0a2819-pr-481/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.2rc2-pkg-838c155f-dev-f3c7a8960acefcf3cdd6a63dca3b8a5f1c0a2819-pr-481/shellcheck-result.xml

Tag Passed
amd64-develop-30.0.2rc2-pkg-838c155f-dev-f3c7a8960acefcf3cdd6a63dca3b8a5f1c0a2819-pr-481
arm64v8-develop-30.0.2rc2-pkg-838c155f-dev-f3c7a8960acefcf3cdd6a63dca3b8a5f1c0a2819-pr-481

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@quietsy quietsy force-pushed the fix-large-files-develop branch from 1572ee2 to 77f8176 Compare January 9, 2025 10:43
@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.4rc1-pkg-73309a55-dev-77f8176c20432ece3566066311717c4567f5c81a-pr-481/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/develop-30.0.4rc1-pkg-73309a55-dev-77f8176c20432ece3566066311717c4567f5c81a-pr-481/shellcheck-result.xml

Tag Passed
amd64-develop-30.0.4rc1-pkg-73309a55-dev-77f8176c20432ece3566066311717c4567f5c81a-pr-481
arm64v8-develop-30.0.4rc1-pkg-73309a55-dev-77f8176c20432ece3566066311717c4567f5c81a-pr-481

@quietsy quietsy merged commit 4c50f93 into develop Jan 9, 2025
@quietsy quietsy deleted the fix-large-files-develop branch January 9, 2025 11:05
@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

This pull request is locked due to inactivity

@linuxserver linuxserver locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants